[ci] Restore custom use-dot-net task #5297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Nov 16, 2020
pjcollins
force-pushed
the
restore-net-cleanup
branch
from
393801e to
a0e2ca1
Compare
Context: dotnet#5293 PR dotnet#5293 introduced an incompatibility with xabuild, and it appears to be causing issues with other stable builds. The [UseDotNet][1] task has a caching feature to improve "installation" times for certain versions, however this can cause issues for our non-hosted build machines. /Users/builder/azdo/_work/_tool/dotnet/sdk/5.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(54,5): error MSB4186: Invalid static method invocation syntax: "[MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')". Method '[MSBuild]::GetTargetFrameworkIdentifier' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(`a`, `b`)). Check that all parameters are defined, are of the correct type, and are specified in the right order. [/Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Java.Interop.GenericMarshaler/Java.Interop.GenericMarshaler.csproj] We should continue to use the custom `use-dot-net` task that Jonathan Peppers added for us during earlier .NET 5 preview work. This template was removed in PR dotnet#5191 but in hindsight it should not have been. [1]: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/tool/dotnet-core-tool-installer?view=azure-devops
pjcollins
force-pushed
the
restore-net-cleanup
branch
from
a0e2ca1 to
2a5663d
Compare
jonathanpeppers
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5293
Context: https://github.com/xamarin/xamarin-android/blob/f5680e783fe45d4f536f8199372ff504ebfdc393/build-tools/automation/yaml-templates/use-dot-net.yaml
PR #5293 introduced an incompatibility with xabuild, and it appears to
be causing issues with other stable builds. The UseDotNet task has
a caching feature to improve "installation" times for certain versions,
however this can cause issues for our non-hosted build machines.
We should continue to use the custom
use-dot-nettask that JonathanPeppers added for us during earlier .NET 5 preview work. This template
was removed in PR #5191 but in hindsight it should not have been.