Android O Preview support #514

atsushieno · 2017-03-22T17:49:54Z

No description provided.

atsushieno · 2017-03-22T17:50:59Z

It also depends on dotnet/java-interop#134 (Java.Interop is not bumped yet)

atsushieno · 2017-03-22T17:56:08Z

How to try to build O preview:
$ AndroidApiLevel=26 AndroidPlatformId=O AndroidFrameworkVersion=7.99.0 make

jonpryor · 2017-03-22T18:14:27Z

build-tools/android-toolchain/android-toolchain.projitems

      <HostOS>Darwin</HostOS>
      <DestDir>platform-tools</DestDir>
    </AndroidSdkItem>
-    <AndroidSdkItem Include="tools_r24.4.1-macosx.zip">
+    <AndroidSdkItem Include="tools_r25.3.1-macosx.zip">


Alas, a tools bump likely means we'll need to deal with the android deprecation, since src/sqlite-xamarin/sqlite-xamarin.targets uses android create project, which no longer exists.

Ouch. :-(

This is failing:

Unable to download URL `https://dl-ssl.google.com/android/repository/tools_r25.3.1-macosx.zip` to `/Users/builder/android-archives/tools_r25.3.1-macosx.zip`: 404 (Not Found)

I am aware of all those download failures. I have no idea what the correct URLs are.

There's also "where should those unstable API stuff go?" problem...

There's also "where should those unstable API stuff go?" problem...

I don't understand the question.

My natural assumption on the Android SDK Tooling is that SDK Tools r25.3.1 and perhaps newer build-tools are required to support Android O API. At least we have to install "platform-O" things. But they are not available via the old Android SDK Manager (in the old SDK Tools). And that new SDK Tools version is only available as Beta version (Beta, Alpha or Canary). That means, to include Android O API support we will have to switch to Beta SDK Tools, even though our stable API is still 24 or 25.

jonpryor · 2017-03-22T18:16:08Z

build-tools/android-toolchain/android-toolchain.projitems

@@ -30,11 +30,11 @@
      <HostOS>Darwin</HostOS>
      <DestDir>build-tools\$(XABuildToolsVersion)</DestDir>
    </AndroidSdkItem>
-    <AndroidSdkItem Include="platform-tools_r23-macosx.zip">
+    <AndroidSdkItem Include="platform-tools_r26.0.0-rc1-macosx.zip">


This is failing:

Unable to download URL `https://dl-ssl.google.com/android/repository/platform-tools_r26.0.0-rc1-macosx.zip` to `/Users/builder/android-archives/platform-tools_r26.0.0-rc1-macosx.zip`: 404 (Not Found)

jonpryor · 2017-03-22T18:17:22Z

Configuration.props

@@ -56,7 +56,7 @@
    <AllSupported32BitTargetAndroidAbis>armeabi;armeabi-v7a;x86</AllSupported32BitTargetAndroidAbis>
    <AllSupported64BitTargetAndroidAbis>arm64-v8a;x86_64</AllSupported64BitTargetAndroidAbis>
    <AllSupportedTargetAndroidAbis>$(AllSupported32BitTargetAndroidAbis);$(AllSupported64BitTargetAndroidAbis)</AllSupportedTargetAndroidAbis>
-    <XABuildToolsVersion>25.0.1</XABuildToolsVersion>
+    <XABuildToolsVersion>26.0.0-rc1</XABuildToolsVersion>


build-tools_r26.0.0-rc1-macosx.zip doesn't exist causing a failure:

Unable to download URL `https://dl-ssl.google.com/android/repository/build-tools_r26.0.0-rc1-macosx.zip` to `/Users/builder/android-archives/build-tools_r26.0.0-rc1-macosx.zip`: 404 (Not Found)

atsushieno · 2017-03-23T13:42:57Z

For future reference, the updated catalog was found at https://dl-ssl.google.com/android/repository/repository2-1.xml . Hopefully it builds now (it did locally).

jonpryor · 2017-03-24T01:26:07Z

@atsushieno: The builds are breaking because make doesn't like us:

build-tools/scripts/BuildEverything.mk:80: *** multiple target patterns.  Stop.

Please rebase on fc22191 or later, which simplifies BuildEverything.mk (adding .PHONY targets, etc.). That might resolve the "multiple t target patterns" error.

atsushieno · 2017-03-25T02:23:59Z

It is not WIP anymore, but I have no idea why Jenkins does not trigger actual builds.

jonpryor · 2017-03-26T12:57:22Z

build

jonpryor · 2017-03-26T15:28:45Z

@atsushieno: It is triggering actual builds, the builds just fail instantly:

build-tools/scripts/BuildEverything.mk:80: *** multiple target patterns.  Stop.

Given that BuildEverything.mk:80 is this

jenkins: prepare leeroy $(ZIP_OUTPUT)

I have to believe that $(ZIP_OUTPUT) contains a :, probably because $(PRODUCT_VERSION) is generating an error:

PRODUCT_VERSION   = $(shell $(MSBUILD) $(MSBUILD_FLAGS) /p:DoNotLoadOSProperties=True /nologo /v:minimal /t:GetProductVersion build-tools/scripts/Info.targets | tr -d '[[:space:]]')

I'm not sure why this would be generating an error; we'll need to try this on the target machine.

atsushieno · 2017-03-27T07:50:03Z

After merging master I could reproduce this, and made some fixes in Configuration.props (there was tag mismatch that I didn't notice when I was building it with overrides for O) and BuildEverything.mk. Let's see if it builds

garuma · 2017-03-27T13:46:14Z

Configuration.props

@@ -31,6 +31,7 @@
    <MonoSgenBridgeVersion Condition=" '$(MonoSgenBridgeVersion)' == '' ">5</MonoSgenBridgeVersion>
    <HOME Condition=" '$(HOME)' == '' ">$(HOMEDRIVE)$(HOMEPATH)</HOME>
    <AndroidApiLevel Condition=" '$(AndroidApiLevel)' == '' ">25</AndroidApiLevel>
+    <AndroidPlatformId Condition=" '$(AndroidPlatformId)' == '' ">25</AndroidPlatformId>


What about making this $(AndroidApiLevel) instead so that the existing build documentation (i.e. only having to specify AndroidApiLevel and AndroidFrameworkVersion to build/override in Configuration.Overrides.props) stays valid?

Do you mean, the default value i.e. <AndroidPlatformId Condition=" '$(AndroidPlatformId)' == '' ">$(AndroidApiLevel)</AndroidPlatformId> ? Yeah that'd be better.

jonpryor · 2017-04-03T19:38:44Z

build-tools/xa-prep-tasks/Xamarin.Android.BuildTools.PrepTasks/AcceptAndroidSdkLicenses.cs

+		public override bool Execute ()
+		{
+			var licdir = Path.Combine (Path.Combine (AndroidSdkDirectory, "licenses"));
+			if (!Directory.Exists (licdir))


This if isn't necessary; Directory.CreateDirectory() doesn't throw if the directory already exists.

atsushieno · 2017-04-04T12:18:42Z

Updated the commit message to explain what has caused the big changes.

atsushieno · 2017-04-18T10:47:34Z

build

jonpryor · 2017-04-25T14:14:13Z

build-tools/android-toolchain/android-toolchain.projitems

    </AndroidSdkItem>
-    <AndroidSdkItem Include="docs-24_r01.zip">


We should continue installing docs.zip.

The changes are big due to the structural changes in Android SDK, particularly that "android" command line tool is gone and they had to be rewritten. Samples that depended on "create" or "update" command had to be checked in as already-created state so that they don't have to bring further dependencies. Changes in the library (Mono.Android) itself is not very big at all.

dnfclas added the cla-already-signed label Mar 22, 2017

atsushieno added the do-not-merge PR should not be merged. label Mar 22, 2017

jonpryor reviewed Mar 22, 2017

View reviewed changes

atsushieno force-pushed the o-preview branch 2 times, most recently from 4746506 to 9e4f1fb Compare March 23, 2017 13:30

atsushieno force-pushed the o-preview branch 2 times, most recently from 0e695a0 to a9cb319 Compare March 23, 2017 17:43

atsushieno force-pushed the o-preview branch from a9cb319 to addd1de Compare March 24, 2017 01:43

atsushieno changed the title ~~[WIP][DO-NOT-MERGE] Android O Preview support~~ Android O Preview support Mar 25, 2017

atsushieno force-pushed the o-preview branch 2 times, most recently from 0e42c59 to f72971a Compare March 27, 2017 07:48

garuma reviewed Mar 27, 2017

View reviewed changes

atsushieno force-pushed the o-preview branch 8 times, most recently from e151f86 to ef06634 Compare March 31, 2017 02:35

jonpryor reviewed Apr 3, 2017

View reviewed changes

atsushieno force-pushed the o-preview branch 2 times, most recently from ca78e09 to e48f8ed Compare April 4, 2017 12:18

atsushieno force-pushed the o-preview branch 2 times, most recently from effc65c to de32868 Compare April 6, 2017 10:11

jonpryor mentioned this pull request Apr 6, 2017

[Xamarin.Android.Build.Tasks] Reduce rebuild cascades #549

Merged

atsushieno force-pushed the o-preview branch from de32868 to 69b17c2 Compare April 6, 2017 12:49

atsushieno force-pushed the o-preview branch 9 times, most recently from 15c7f92 to 1f6f18c Compare April 18, 2017 10:07

atsushieno force-pushed the o-preview branch 5 times, most recently from 6c2e85b to 9cfb7ba Compare April 18, 2017 19:59

[Mono.Android] Add api-O.xml.in.

f438060

atsushieno force-pushed the o-preview branch from 9cfb7ba to c2c6fa6 Compare April 25, 2017 05:24

jonpryor reviewed Apr 25, 2017

View reviewed changes

atsushieno force-pushed the o-preview branch from c2c6fa6 to 245b27c Compare April 25, 2017 14:59

jonpryor merged commit 571546a into dotnet:master Apr 25, 2017

github-actions bot locked and limited conversation to collaborators Feb 5, 2024

Android O Preview support #514

Android O Preview support #514

Uh oh!

Conversation

atsushieno commented Mar 22, 2017

Uh oh!

atsushieno commented Mar 22, 2017

Uh oh!

atsushieno commented Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonpryor Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonpryor Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atsushieno commented Mar 23, 2017

Uh oh!

jonpryor commented Mar 24, 2017

Uh oh!

atsushieno commented Mar 25, 2017

Uh oh!

jonpryor commented Mar 26, 2017

Uh oh!

jonpryor commented Mar 26, 2017

Uh oh!

atsushieno commented Mar 27, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atsushieno Mar 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

atsushieno commented Apr 4, 2017

Uh oh!

atsushieno commented Apr 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

atsushieno commented Mar 22, 2017 •

edited

Loading

jonpryor Mar 22, 2017 •

edited

Loading

jonpryor Mar 22, 2017 •

edited

Loading

atsushieno Mar 27, 2017 •

edited

Loading