[tests] MSBuild performance raise expected times by 100ms #3887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://build.azdo.io/3218699 Context: https://build.azdo.io/3219042 Context: https://build.azdo.io/3219928 Raising some of the expected times, as we have seen some random failures that do not appear to be performance regressions. The assertion failures were: Build_No_Changes: Exceeded expected time of 3250ms, actual 3270ms Build_CSharp_Change: Exceeded expected time of 4000ms, actual 4050ms Build_AndroidResource_Change: Exceeded expected time of 4750ms, actual 4770ms Build_XAML_Change(True,False): Exceeded expected time of 6250ms, actual 6270ms Build_XAML_Change(False,False): Exceeded expected time of 9500ms, actual 9560ms
jonathanpeppers
force-pushed
the
perf-tests-100ms
branch
from
c063fee to
040f83e
Compare
Member
Author
|
It looks like the new times are working, I think we can go ahead and merge this. |
jonpryor
pushed a commit
that referenced
this pull request
Nov 20, 2019
Context: https://build.azdo.io/3218699 Context: https://build.azdo.io/3219042 Context: https://build.azdo.io/3219928 Raising some of the expected times, as we have seen some random failures that do not appear to be performance regressions. The assertion failures were: Build_No_Changes: Exceeded expected time of 3250ms, actual 3270ms Build_CSharp_Change: Exceeded expected time of 4000ms, actual 4050ms Build_AndroidResource_Change: Exceeded expected time of 4750ms, actual 4770ms Build_XAML_Change(True,False): Exceeded expected time of 6250ms, actual 6270ms Build_XAML_Change(False,False): Exceeded expected time of 9500ms, actual 9560ms
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://build.azdo.io/3218699
Context: https://build.azdo.io/3219042
Raising some of the expected times, as we have seen some random
failures that do not appear to be performance regressions.
The assertion failures were: