[build] archive APKs/AABs in yaml #3886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 22de117, it did not actually archive *all* `.apk` files. Throughout our build pipeline, we build projects with different MSBuild properties as input such as `/p:AotAssemblies=True`. This causes the `.apk` files to be overwritten, and we lose them... Instead, we should copy each APK to a directory inside `$(Build.ArtifactStagingDirectory)` with a path identifying. And so I propose modifying the template such as: - template: yaml-templates/apk-instrumentation.yaml parameters: configuration: $(ApkTestConfiguration) testName: Mono.Android_Tests-Aot project: src/Mono.Android/Test/Mono.Android-Tests.csproj testResultsFiles: TestResult-Mono.Android_Tests-$(ApkTestConfiguration)-Aot.xml extraBuildArgs: /p:AotAssemblies=True /p:EnableLlvm=True artifactName: Mono.Android_Tests-Signed.apk artifactFolder: Aot Would yield an artifact at `Aot/Mono.Android_Tests-Signed.apk` that we could download independently.
jonathanpeppers
force-pushed
the
archive-apks
branch
from
f699dba to
cc2691f
Compare
Member
Author
|
The last build before I did some squashing & cleanup looked like what we need: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3220679&view=artifacts
|
pjcollins
approved these changes
Nov 7, 2019
jonpryor
reviewed
Nov 7, 2019
jonpryor
reviewed
Nov 7, 2019
jonpryor
reviewed
Nov 7, 2019
Merged
jonpryor
pushed a commit
that referenced
this pull request
Nov 8, 2019
In 22de117, it did not actually archive *all* the `.apk` files. Throughout our build pipeline, we build projects with different MSBuild properties as input such as `/p:AotAssemblies=True`. This causes the `.apk` files to be overwritten, and we lose the previous versions of these files. Instead, we should copy each APK to a directory inside `$(Build.ArtifactStagingDirectory)` with a path identifying which MSBuild properties were set during the build. I propose modifying the template such as: - template: yaml-templates/apk-instrumentation.yaml parameters: configuration: $(ApkTestConfiguration) testName: Mono.Android_Tests-Aot project: src/Mono.Android/Test/Mono.Android-Tests.csproj testResultsFiles: TestResult-Mono.Android_Tests-$(ApkTestConfiguration)-Aot.xml extraBuildArgs: /p:AotAssemblies=True /p:EnableLlvm=True artifactName: Mono.Android_Tests-Signed.apk artifactFolder: AotLlvm Would yield an artifact at `AotLlvm/Mono.Android_Tests-Signed.apk` that we could download independently, and *won't* overwrite other "build versions" of the "same" App. ![AzDO Artifacts Image][0] [0]: https://user-images.githubusercontent.com/840039/68357624-8eb0a300-00db-11ea-9761-2f1b7ebf5b66.png
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 22de117, it did not actually archive all
.apkfiles.Throughout our build pipeline, we build projects with different
MSBuild properties as input such as
/p:AotAssemblies=True. Thiscauses the
.apkfiles to be overwritten, and we lose them...Instead, we should copy each APK to a directory inside
$(Build.ArtifactStagingDirectory)with a path identifying.And so I propose modifying the template such as:
Would yield an artifact at
Aot/Mono.Android_Tests-Signed.apkthat wecould download independently.