-
Notifications
You must be signed in to change notification settings - Fork 552
[ci] Add API Compatibility job to Azure Pipelines #3644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ababc6
to
12c7a31
Compare
Context: dotnet#3607 Adds a new job to the Azure Pipelines 'Test' stage which downloads, installs, and runs API compatibility checks against the .pkg installer produced by the macOS build job.
pjcollins
added a commit
to xamarin/xamarin-android-api-compatibility
that referenced
this pull request
Sep 18, 2019
Context: dotnet/android#3644 xamarin-android/pull/3644 introduces an Azure Pipelines job to run API compatibility checks against an installed .pkg file that was produced by a previous step in the pieline. This new check appears to be failing due to the fact that our installer includes `Mono.Android.Export.dll` and `OpenTK-1.0.dll` in the first target framework directory that it creates rather than the last. We'll now check the first target framework directory for these relevant assemblies, and only attempt to use the latest if the first doesn't exist to address this. An additional check has also been added to ensure that every expected API info file is successfully created, regardless of content.
This should be ready to go, but it depends on the changes in xamarin/xamarin-android-api-compatibility#23 |
jonpryor
pushed a commit
to xamarin/xamarin-android-api-compatibility
that referenced
this pull request
Sep 19, 2019
Context: dotnet/android#3644 dotnet/android#3644 introduces an Azure Pipelines job to run API compatibility checks against an installed `.pkg` file that was produced by a previous step in the build pipeline. This new check appears to be failing due to the fact that our installer includes `Mono.Android.Export.dll` and `OpenTK-1.0.dll` in the *first* target framework directory that it creates rather than all of them. We'll now check the first target framework directory for these relevant assemblies, and only attempt to use the latest if the first doesn't exist to address this, which would happen on PR builds. An additional check has also been added to ensure that every expected API info file is successfully created, regardless of content.
xamarin/xamarin-android-api-compatibility#23 has been merged, this should be ready to go assuming we get a green api-compatibility check on this latest run. |
jonpryor
pushed a commit
that referenced
this pull request
Sep 20, 2019
Context: 4733cba Changes: xamarin/xamarin-android-api-compatibility@336eeda...a61271e Bumps to xamarin/xamarin-android-api-compatibility@a61271e0 Adds a new **API Compatibility** job to the Azure Pipelines 'Test' stage which downloads, installs, and runs API compatibility checks against the `.pkg` installer produced by the macOS build job. This allows our Azure DevOps-based pipeline to report API breakage, instead of requiring and relying on the previous Jenkins builds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #3607
Adds a new job to the Azure Pipelines 'Test' stage which downloads,
installs, and runs API compatibility checks against the .pkg installer
produced by the macOS build job.