[C++ification] Glue and utilities code changes #2611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
added
do-not-merge
grendello
force-pushed
the
cppify+2
branch
5 times, most recently
from
9fbb8eb to
d450659
Compare
* Use `new/delete/delete[]` more
* Avoid calling the `printf` family of functions in favor of new, template,
`string_concat` in the `Utils` class. When `sprintf` is used to concatenate
just strings we can do better by not calling the C varargs functions and
generate very efficient code.
* Replace C `strdup` calls with our, based on `new`, strdup implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new/delete/delete[]moreprintffamily of functions in favor of new, template,string_concatin theUtilsclass. Whensprintfis used to concatenate just strings we can do better by not calling the C varargs functions and generate very efficient code.strdupcalls with our, based onnew, strdup implementation