[Xamarin.Android.Build.Tasks] Fixed F# Resource Designer compilation issues [DONT MERGE] #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Personally, if this works as we expect, I think we should move ALL project types over to using the |
dellis1972
changed the title
dellis1972
force-pushed
the
fsharpresources
branch
from
a1cb860 to
a9647c5
Compare
Contributor
Author
|
The problem with this so far is the C# code is generated in Resource.Designer.fs . |
dellis1972
force-pushed
the
fsharpresources
branch
from
a9647c5 to
3e3a326
Compare
Contributor
|
I know this isn't finished yet, but just reporting my findings.
This causes a warning in the editor before build
I also get two red squiggles in the editor
Would it be possible to include After building (and making a random edit) everything looks fine :-
"Bug 42840 Unable to build F# Android project with F# Class Library." is fixed by this change. I wasn't able to test the mixed F#/C# solution bugs, because this PR breaks C# :) But I would expect them to just work. |
dellis1972
force-pushed
the
fsharpresources
branch
from
3e3a326 to
585ab90
Compare
…issues The latest release of F# removed support for static fields. As a result the Resource.Designer.fs file that wes being generated by our build system no longer compiled. This commit reworks the Designer.cs code to emit a C# assembly for F# projects rather than just the code. This has the benifit of us not having to produce F# code in the first place. The new system works as follows. 1) GenerateResourceDesigner Task generates a Resources.Designer.cs file as normal 2) If the target project is F# that file is then compiled into a Resource.Designer.dll 3) The new .dll is then included in the @ReferencePaths ItemGroup 4) The Resource.Designer.cs is removed from the @complie ItemGroup If the project is C# or VS the Designer file is just included as normal.
dellis1972
force-pushed
the
fsharpresources
branch
from
585ab90 to
f91700b
Compare
Contributor
|
@nosami, @dellis1972: what's the status of this PR? Should we merge this for XA 7.2? Does it need testing, QA? What are the QA implications of this PR? |
Contributor
Author
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Without this, abstract classes that implement `java.time.chrono.Chronology` fail to bind because they will try to implement those static properties as instance (this check had been done for methods, but not for properties).
jonpryor
pushed a commit
that referenced
this pull request
Jan 28, 2020
Context: #238 Context: #4132 Removes the use of F# CodeDOM for generating the resource designer file for F#. Instead, the [Xamarin.Android.FSharp.ResourceProvider][0] type provider will be used at compile time -- via both `msbuild` and the IDE -- which will compile the C# `Resource.Designer.cs` file and make the types available to the consuming F# project. The type provider is available as a [NuGet package][1] and is included in the Android templates. This is conceptually similar to [PR #159][2], but uses an F# type provider to compile the C# code instead of an MSBuild task. The advantage of this method is that IntelliSense works within the IDE without needing to change the IDE code. [0]: https://github.com/xamarin/Xamarin.Android.FSharp.ResourceProvider [1]: https://www.nuget.org/packages/Xamarin.Android.FSharp.ResourceProvider [2]: #159 Co-authored-by: Jason Imison <nosami@users.noreply.github.com>
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 16, 2022
Changes: dotnet/android-tools@f4c44e2...fc3c2ac * dotnet/android-tools@fc3c2ac: Bump to Microsoft.VisualStudioEng.MicroBuild.Core 1.0.0 (dotnet#159)
jonpryor
added a commit
that referenced
this pull request
Mar 17, 2022
Changes: dotnet/android-tools@f4c44e2...fc3c2ac * dotnet/android-tools@fc3c2ac: Bump to Microsoft.VisualStudioEng.MicroBuild.Core 1.0.0 (#159)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of F# removed support for static fields. As a result
the Resource.Designer.fs file that wes being generated by our build
system no longer compiled.
This commit reworks the Designer.cs code to emit a C# assembly for
F# projects rather than just the code. This has the benifit of
us not having to produce F# code in the first place.
The new system works as follows.
If the project is C# or VS the Designer file is just included as normal.