-
Notifications
You must be signed in to change notification settings - Fork 565
Update F# targets imports #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mhutch
commented
Aug 3, 2016
- Make consistent with xamarin-ios
- Add modern $(VisualStudioVersion)-based import
- Add 4.0 import, remove 3.0 import
* Make consistent with xamarin-ios * Add modern $(VisualStudioVersion)-based import * Add 4.0 import, remove 3.0 import
|
Hi @mhutch, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
|
(see also dotnet/macios#541) |
|
@radical: Please review this PR. Additionally, I have no idea how this PR interacts with our desired F# policy of "provide your own NuGet package": https://bugzilla.xamarin.com/show_bug.cgi?id=41262
|
|
It doesn't interact with it at all. This is for the build, not the standard library. Unless you're also suggesting we deprecate this target and require one to be shipped in the aforementioned NuGet. |
I have no idea, which is why I asked. :-) Is there any connection between the build system and the referenced |
|
The referenced FSharp.Core.dll file is a project template issue - it's not connected to this PR. I've tested this PR along with NuGet'd FSharp.Core - no issues. |
* Make consistent with xamarin-ios * Add modern `$(VisualStudioVersion)`-based import * Add 4.0 import, remove 3.0 import
[dependencies] Bump cecil to match the one used in 2017-04.
Changes: dotnet/android-tools@a5194e9...0a22957 * dotnet/android-tools@0a22957: [Xamarin.Android.Tools.AndroidSdk] Parse Properties after header (dotnet#143) * dotnet/android-tools@dac3a47: [Xamarin.Android.Tools.AndroidSdk] Add API-31 to KnownVersions (dotnet#141) * dotnet/android-tools@fc976d8: [Xamarin.Android.Tools.AndroidSdk] Add JdkInfo.GetSupportedJdkInfos() (dotnet#142) * dotnet/android-tools@34e98e2: [build] Allow Assembly "vendorization" (dotnet#136) * dotnet/android-tools@061bcc2: [build] Import "parent directory.override.targets" (dotnet#135)
Changes: dotnet/android-tools@a5194e9...0a22957 * dotnet/android-tools@0a22957: [Xamarin.Android.Tools.AndroidSdk] Parse Properties after header (#143) * dotnet/android-tools@dac3a47: [Xamarin.Android.Tools.AndroidSdk] Add API-31 to KnownVersions (#141) * dotnet/android-tools@fc976d8: [Xamarin.Android.Tools.AndroidSdk] Add JdkInfo.GetSupportedJdkInfos() (#142) * dotnet/android-tools@34e98e2: [build] Allow Assembly "vendorization" (#136) * dotnet/android-tools@061bcc2: [build] Import "parent directory.override.targets" (#135)