[Xamarin.Android.Build.Tasks] Update NdkUtils to read the idk version from source.properties #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!File.Exists (sourcePropertiesPath)) { | ||
| return false; | ||
| } | ||
| var match = Regex.Match (File.ReadAllText (sourcePropertiesPath).Trim (), "(\\d+).(\\d+).(\\d+)"); |
Contributor
There was a problem hiding this comment.
I don't like this regex, as it could match nearly anything, and I'm not sure I want to rely on source.properties only ever containing two lines, one of which only containing one dotted number.
I would instead prefer matching on:
^Pkg.Revision\s*=\s*([.0-9]+)$
This way we ensure we only grab the value of the Pkg.Revision "key".
… from source.properties Google has removed the RELEASE.txt from the latest ndk version in favour of a source.properties file. This commit adds support for reading the version from this new file.
radekdoulik
pushed a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Aug 12, 2016
…dotnet#138) Google has removed the RELEASE.txt from the latest ndk version in favour of a source.properties file. This commit adds support for reading the version from this new file.
radical
pushed a commit
that referenced
this pull request
May 8, 2018
Fixes reading/writing the size of table indexes in external pdb files.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google has removed the RELEASE.txt from the latest ndk version in
favour of a source.properties file.
This commit adds support for reading the version from this new
file.