Repository navigation
Default legacy compatibility assembly fixups off - #12925
Open
jonathanpeppers wants to merge 1 commit into
Open
jonathanpeppers wants to merge 1 commit into
jonathanpeppers wants to merge 1 commit into
Conversation
Gate existing trimmed LLVM-IR compatibility steps on the opt-in property while preserving unrelated post-trim diagnostics. Cover default and opt-in behavior in build tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Trimmed LLVM-IR and default-off device behavior lack coverage, and public documentation still states the old default.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Changes LLVM-IR legacy compatibility assembly fixups to be disabled by default while preserving explicit opt-in behavior.
Changes:
- Gates untrimmed and post-trimming fixup passes behind the opt-in property.
- Preserves trimmable type-map behavior.
- Updates unit, build, and device test scenarios.
| File | Summary |
|---|---|
tests/MSBuildDeviceIntegration/Tests/InstallAndRunTests.cs |
Enables opt-in fixups; needs a paired default-off test. |
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Tasks/LinkerTests.cs |
Tests fixup defaults and opt-in behavior. |
src/Xamarin.Android.Build.Tasks/Tasks/PostTrimmingPipeline.cs |
Propagates post-trimming fixup gating; trimmed behavior needs coverage. |
src/Xamarin.Android.Build.Tasks/Tasks/LinkAssembliesNoShrink.cs |
Defaults fixups to disabled. |
src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.TypeMap.LlvmIr.targets |
Changes the LLVM-IR default and wiring; documentation and trimmed coverage need updates. |
src/Xamarin.Android.Build.Tasks/Linker/MonoDroid.Tuner/PostTrimmingFixAbstractMethodsStep.cs |
Conditionally applies abstract-method fixups; both flag states need test coverage. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AndroidEnableLegacyCompatibilityAssemblyFixupstofalsefor LLVM-IR builds; retain the existingfalsedefault for trimmable type maps.Validation
git diff --check.bin/BuildDebug/net10.0/xa-prep-tasks.dll, the local SDK, and restored test assets (MSB4062/NETSDK1004).Public documentation was left untouched as requested.