Skip to content

Add "AndroidManifest resource collection and generate information" tool. #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2017
Merged

Add "AndroidManifest resource collection and generate information" tool. #1096

merged 1 commit into from
Dec 21, 2017

Conversation

atsushieno
Copy link
Contributor

No description provided.

@jonpryor
Copy link
Contributor

build

@jonpryor
Copy link
Contributor

I assume that the intent of this tool is to replace/supplement all of the e.g. ActivityAttribute custom attributes used between Mono.Android.dll and Xamarin.Android.Build.Tasks.dll.

Should the introduction of the tool be alongside the presumed custom attribute behavior? If the tool and the new use is in the same PR, it's easier to see how these pieces fit together.

@atsushieno atsushieno force-pushed the manifest-attribute-codegen branch from d7ca5ec to d4e6a67 Compare December 13, 2017 08:47
@atsushieno
Copy link
Contributor Author

atsushieno commented Dec 13, 2017 •
edited
Loading

It is not really for generating code. Right, I thought it's good, but I thought about it again and concluded it's not worthy. It is enough that we can find which elements and attributes are new.

@jonpryor
Copy link
Contributor

It is enough that we can find which elements and attributes are new.

Fair enough.

Could you please write some documentation on how to use this tool? Presumably it could be part of Documentation/HowToAddNewApiLevel.md (as we'll want to review the attributes on API level bumps).

@jonpryor jonpryor merged commit e790874 into dotnet:master Dec 21, 2017
jonpryor added a commit to jonpryor/xamarin-android that referenced this pull request Jun 4, 2020
@jonpryor
Bump to xamarin/monodroid/d16-7@0d0e4527
c75708c 
Changes: https://github.com/xamarin/monodroid/compare/8d51d0af0572db1583a8ab5ec095bec3046ae476...0d0e4527f142e73bdff9fa1b63349bb0a1631900

Context: 5bba16e

  * xamarin/monodroid@0d0e4527f: Bump to xamarin/androidtools/d16-7@315b97be (dotnet#1096)
@jonpryor jonpryor mentioned this pull request Jun 4, 2020
Merged
jonpryor added a commit that referenced this pull request Jun 5, 2020
@jonpryor
Bump to xamarin/monodroid/d16-7@0d0e4527 (#4766)
0b233e8 
Changes: https://github.com/xamarin/monodroid/compare/8d51d0af0572db1583a8ab5ec095bec3046ae476...0d0e4527f142e73bdff9fa1b63349bb0a1631900

Context: 5bba16e

  * xamarin/monodroid@0d0e4527f: Bump to xamarin/androidtools/d16-7@315b97be (#1096)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atsushieno @jonpryor