[xabuild] support <PackageReference /> #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `NetStandardReferenceTest` has been failing on Windows due to its use of `<PackageReference />`. Windows appears to need to import two files: - C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\NuGet\15.0\Microsoft.NuGet.props - C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\NuGet\15.0\Microsoft.NuGet.targets Luckily we can set two properties to specify these paths: `$(NuGetProps)` and `$(NuGetTargets)`. I think this is only a problem on Windows, as these files aren't present on macOS.
dellis1972
approved these changes
Dec 7, 2017
|
Whoops I just found these on Mac: I think I need to test this on Mac, forcing the tests to run under MSBuild. |
|
The NetStandard Test already does run under msbuild by default on Mac. So
you should see the results in the PR builder.
…On 7 December 2017 at 17:45, Jonathan Peppers ***@***.***> wrote:
Whoops I just found these on Mac:
/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/xbuild/Microsoft/NuGet/Microsoft.NuGet.targets
/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/xbuild/Microsoft.NuGet.targets
/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/xbuild/NuGet.targets
I think I need to test this on Mac, forcing the tests to run under MSBuild.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1083 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxeeZhxb4xeXBMYhxNVO-ROr6rPFbKZks5s-CQvgaJpZM4Q554B>
.
|
|
Yeah, it worked when I tried it locally. I don't know why we have to include all these crazy properties just for Windows... |
|
@dellis1972 Is PackageReference support for XA projects on Linux? (given the latest mono and the xplat-master build of MSBuild are both installed) |
|
@borgdylan this PR is specifically around I think |
|
Thanks for the insight. Support for the new project system would be a massive help for devs who use VSCode only or are on Linux. |
|
build |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Apr 18, 2020
Changes: https://github.com/xamarin/monodroid/compare/846697287fb32c38b54ddd2fe21964b9159b2750...16cb1cb1ac7c472207023953b7bb3970f7c9aa54 * xamarin/monodroid@16cb1cb1a: Bump to xamarin/androidtools/master@068e4f5 (dotnet#1084) * xamarin/monodroid@8f61f0cae: Bump to xamarin/android-sdk-installer/master@d9276b4 (dotnet#1085) * xamarin/monodroid@bec720cd0: Bump to xamarin/jar2xml@4125da65 (dotnet#1083) * xamarin/monodroid@a49e901d6: [tools/msbuild] update <BuildApk/> task inputs (dotnet#1082) * xamarin/monodroid@b9f16c002: Bump to xamarin/androidtools/master@5412dc8 (dotnet#1081) * xamarin/monodroid@673a74961: [.NET 5] fix for ALC isolation between assemblies (dotnet#1080)
jonpryor
added a commit
that referenced
this pull request
Apr 19, 2020
Changes: https://github.com/xamarin/monodroid/compare/846697287fb32c38b54ddd2fe21964b9159b2750...16cb1cb1ac7c472207023953b7bb3970f7c9aa54 * xamarin/monodroid@16cb1cb1a: Bump to xamarin/androidtools/master@068e4f5 (#1084) * xamarin/monodroid@8f61f0cae: Bump to xamarin/android-sdk-installer/master@d9276b4 (#1085) * xamarin/monodroid@bec720cd0: Bump to xamarin/jar2xml@4125da65 (#1083) * xamarin/monodroid@a49e901d6: [tools/msbuild] update <BuildApk/> task inputs (#1082) * xamarin/monodroid@b9f16c002: Bump to xamarin/androidtools/master@5412dc8 (#1081) * xamarin/monodroid@673a74961: [.NET 5] fix for ALC isolation between assemblies (#1080)
jonpryor
added a commit
that referenced
this pull request
Apr 23, 2020
Changes: https://github.com/xamarin/monodroid/compare/70a11642ad39b6b647e02f0df62c84f8e6c2e1f9...d35c4221bb1c9b52b5280a4380598aaa95b332b8 * xamarin/monodroid@d35c4221b: Bump to xamarin/jar2xml@4125da65 (#1083) * xamarin/monodroid@ea68087b0: [tools/msbuild] update <BuildApk/> task inputs (#1082) * xamarin/monodroid@16c2eb29e: Bump to xamarin/androidtools/d16-7@fba677c4 (#1081) * xamarin/monodroid@53abd4f03: [.NET 5] fix for ALC isolation between assemblies (#1080)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NetStandardReferenceTesthas been failing on Windows due to itsuse of
<PackageReference />.Windows appears to need to import two files:
Luckily we can set two properties to specify these paths:
$(NuGetProps)and$(NuGetTargets). I think this is only a problem onWindows, as these files aren't present on macOS.