[Xamarin.Android.Build.Tasks] don't set $(UseMonoRuntime) by default
#10527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
dev/peppers/usemonoruntime
branch
from
ad0ed28 to
c9bb3bb
Compare
|
I assume this means that in .NET 11 CoreCLR will be the default runtime… |
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
4 times, most recently
from
dbf485e to
8000aef
Compare
| <_AndroidRuntime Condition=" '$(PublishAot)' == 'true' and '$(UseMonoRuntime)' != 'true' ">NativeAOT</_AndroidRuntime> | ||
| <_AndroidRuntime Condition=" '$(PublishAot)' != 'true' and '$(UseMonoRuntime)' != 'true' ">CoreCLR</_AndroidRuntime> | ||
| <_AndroidRuntime Condition=" '$(_AndroidRuntime)' == '' ">MonoVM</_AndroidRuntime> | ||
| <_AndroidRuntime Condition=" '$(PublishAot)' == 'true' ">NativeAOT</_AndroidRuntime> |
There was a problem hiding this comment.
What happens in Debug builds when you have <PublishAot>true</PublishAot> in the project file? Does it try to still run with NativeAOT? For "PublishAOT Debug builds", I believe we need to use CoreCLR 🤔 I suppose we can fix that later though.
There was a problem hiding this comment.
I think in this case it will try to use Mono AOT as it is now, at least the error messages I've seen suggest that. Yeah, we can't use NativeAOT for debug builds.
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
from
8000aef to
0ead24b
Compare
This requires some more tweaking, tbc tomorrow
…files DotNetBuildLibrary test fully works now
Which is weird, it should work for MonoVM at least but.. it doesn't. TBC
Making the test work for CoreCLR and NativeAOT is a more involved affair, requires testing each set of parameters individually as changing any of them changes the code, which needs to be verified. Also, the previous changes somehow made the previously working Mono tests to fail. Let's leave it for later.
grendello
force-pushed
the
dev/peppers/usemonoruntime
branch
from
0ead24b to
3492e3f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.