Skip to content

[ci] remove $(MicroBuildSignType) variable #10521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

[ci] remove $(MicroBuildSignType) variable #10521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions build-tools/automation/azure-pipelines.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,9 @@ variables:
- ${{ if ne(variables['Build.DefinitionName'], 'Xamarin.Android-Private') }}:
- name: DotNetFeedCredential
value: dnceng-dotnet9
- name: MicroBuildSignType
${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
value: Real
${{ else }}:
value: Test

extends:
${{ if eq(variables['MicroBuildSignType'], 'Real') }}:
${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
template: azure-pipelines/MicroBuild.1ES.Official.yml@1esPipelines
${{ else }}:
template: azure-pipelines/MicroBuild.1ES.Unofficial.yml@1esPipelines
Expand Down Expand Up @@ -257,7 +252,10 @@ extends:
name: sign_net_mac_win
poolName: $(VSEngMicroBuildPool)
artifactName: $(NuGetArtifactName)
signType: $(MicroBuildSignType)
${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
signType: Real
${{ else }}:
signType: Test
signedArtifactName: nuget-signed
usePipelineArtifactTasks: true
uploadPrefix: sign-mac-win
Expand All @@ -271,7 +269,10 @@ extends:
displayName: Sign Linux Archive
poolName: $(VSEngMicroBuildPool)
artifactName: $(LinuxNuGetArtifactName)
signType: $(MicroBuildSignType)
${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
signType: Real
${{ else }}:
signType: Test
signedArtifactName: nuget-linux-signed
usePipelineArtifactTasks: true
uploadPrefix: sign-linux
Expand All @@ -287,7 +288,10 @@ extends:
artifactPatterns: |
!*Darwin*
propsArtifactName: $(NuGetArtifactName)
signType: $(MicroBuildSignType)
${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
signType: Real
${{ else }}:
signType: Test
preConvertSteps:
- task: DownloadPipelineArtifact@2
inputs:
Expand Down
2 changes: 1 addition & 1 deletion build-tools/automation/yaml-templates/commercial-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ steps:

- task: DotNetCoreCLI@2
displayName: macOS signing - add runtime entitlements
condition: and(succeeded(), eq(variables['MicroBuildSignType'], 'Real'))
condition: and(succeeded(), and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')))
inputs:
projects: ${{ parameters.xaSourcePath }}/build-tools/installers/sign-content.proj
arguments: >-
Expand Down
6 changes: 4 additions & 2 deletions build-tools/automation/yaml-templates/install-microbuild-tooling.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
parameters:
signType: $(MicroBuildSignType)
condition: succeeded()

steps:
Expand All @@ -23,7 +22,10 @@ steps:
displayName: install signing plugin
condition: ${{ parameters.condition }}
inputs:
signType: ${{ parameters.signType }}
${{ if and(startsWith(variables['Build.SourceBranch'], 'refs/heads/release/'), ne(variables['Build.Reason'], 'PullRequest'), eq(variables['Build.DefinitionName'], 'Xamarin.Android')) }}:
signType: Real
${{ else }}:
signType: Test
azureSubscription: MicroBuild Signing Task (DevDiv)
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
Loading