[tests] Simplify CreateDllBuilder() and CreateApkBuilder() calls to use default parameters #10373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies MSBuild integration test code by removing redundant explicit directory parameters from
CreateDllBuilder()andCreateApkBuilder()calls where the default behavior already provides the same result.Changes Made
The
BaseTest.CreateDllBuilder()andBaseTest.CreateApkBuilder()methods have default parameters that automatically usePath.Combine("temp", TestName)when no directory is specified. Many tests were explicitly passing this same path, making the code more verbose than necessary.Before:
After:
Scope
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/(11 files)tests/MSBuildDeviceIntegration/Tests/(6 files)What Was NOT Changed
To preserve intentional test behavior, the following patterns were left unchanged:
Path.Combine("temp", TestName, libproj.ProjectName))cleanupOnDispose: false)"temp/ApplicationJavaClassProperties")BuildHelper.CreateApkBuildercalls (different method with different signature)Validation
This cleanup makes the test code more concise and consistent by leveraging the existing default parameter behavior.
Fixes #10372.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.