Skip to content

Set a default for the Http3Support feature switch #10251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

MichalStrehovsky
Copy link
Member

Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.

Ref dotnet/runtime#117012
Ref dotnet/sdk#49564

Control over this is moving from dotnet/runtime repo build time to publish time so we need to set a default that matches the old build-time setting.

Ref dotnet/runtime#117012
Ref dotnet/sdk#49564
Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Michal!

@grendello
Copy link
Contributor

Since it's a potentially breaking change (it removes something by default where it was present before and moves the responsibility for this to app developers), can you add documentation for this new default and how to enable HTTP3 support?

I think the best place would be somewhere in this file, since the content of the Documentation/docs-mobile/ directory is mirrored to https://learn.microsoft.com/en-gb/dotnet/android/ (eventually)

@jonathanpeppers do you agree we should document this in the above location?

@vitek-karas
Copy link
Member

I don't think this ever worked on Android. It needs msquick library which AFAIK we never shipped for Android.
@liveans can you confirm if this worked before on Android?

@grendello
Copy link
Contributor

I don't think this ever worked on Android. It needs msquick library which AFAIK we never shipped for Android. @liveans can you confirm if this worked before on Android?

If this is so, then there wouldn't be any need to document this, indeed. Not unless we plan to start supporting it on Android at some point?

@liveans
Copy link
Member

liveans commented Jun 27, 2025

I don't think this ever worked on Android. It needs msquick library which AFAIK we never shipped for Android.

@liveans can you confirm if this worked before on Android?

No, we don't officially support QUIC on Android, as a result we don't support HTTP/3 on Android. However, it might be possible for users to compile msquic themselves and use it.

cc @ManickaP

@MichalStrehovsky
Copy link
Member Author

No, we don't officially support QUIC on Android, as a result we don't support HTTP/3 on Android. However, it might be possible for users to compile msquic themselves and use it.

Yep and before this feature switch got introduced in dotnet/runtime#117012, not even building your own libmsquic would be enough because it was force disabled in System.Net.Http. With this feature switch the user will have an option to flip the switch and experiment if they really want.

Android behavior was discussed at dotnet/runtime#117012 (comment).

@jonathanpeppers
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonathanpeppers
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures are because the PR is from a fork:

XYZ requires a commercial build of .NET for Android.

With the team changes, I should probably look into these and make the tests ignore instead of fail.

@jonathanpeppers jonathanpeppers merged commit 9404ad2 into dotnet:main Jun 27, 2025
52 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants