[build] introduce $(PackageVersionSuffix) for dotnet/android
#259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows dotnet/android to add a `-preview.$(PackVersionCommitCount)` suffix for any `.nupkg` packages produced by this repo.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for adding version suffixes to NuGet packages by implementing a $(PackageVersionSuffix) property in the build system. This change enables dotnet/android to append preview version suffixes (like -preview.$(PackVersionCommitCount)) to package versions while maintaining the base version structure.
- Modifies the
SetVersiontarget to concatenate$(PackageVersionSuffix)to the base version when settingPackageVersion
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Jul 23, 2025
Context: dotnet/android-tools#259 This adds the suffix: <PackageVersionSuffix>-preview.$(PackVersionCommitCount)</PackageVersionSuffix> In order to allow the package to be published as a "transport" package with a non-stable version: packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.25367.5\tools\SdkTasks\PublishArtifactsInManifest.proj(124,5): error : Package 'Xamarin.Android.Tools.AndroidSdk' has stable version '1.0.104' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10/nuget/v3/index.json'
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Jul 23, 2025
Context: dotnet/android-tools#259 This adds the suffix: <PackageVersionSuffix>-preview.$(PackVersionCommitCount)</PackageVersionSuffix> In order to allow the package to be published as a "transport" package with a non-stable version: packages\microsoft.dotnet.arcade.sdk\10.0.0-beta.25367.5\tools\SdkTasks\PublishArtifactsInManifest.proj(124,5): error : Package 'Xamarin.Android.Tools.AndroidSdk' has stable version '1.0.104' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet10/nuget/v3/index.json' I also set this logic to only run when `$(IsPacking)` is true, as there are build ordering problems during `make prepare` without doing this. The bootstrap tasks `.dll`'s don't exist then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows dotnet/android to add a
-preview.$(PackVersionCommitCount)suffix for any.nupkgpackages produced by this repo.