-
Notifications
You must be signed in to change notification settings - Fork 31
[BaseTasks] Import Xamarin.Build.AsyncTask #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We've decided to move https://github.com/xamarin/Xamarin.Build.AsyncTask into this repository as part of dotnet org migration efforts. Source and test content from xamarin/Xamarin.Build.AsyncTask@db4ce14dac has been added to Microsoft.Android.Build.BaseTasks.
@dellis1972 @jonathanpeppers I think this should be ready for further review and hopefully good to go now. I just bumped
The downstream PRs are all looking good so far against these latest changes as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 The main fallout will be bumping a lot of things everywhere!
We've decided to move https://github.com/xamarin/Xamarin.Build.AsyncTask
into this repository as part of dotnet org migration efforts.
Source and test content from xamarin/Xamarin.Build.AsyncTask@db4ce14dac
has been added to Microsoft.Android.Build.BaseTasks.
The
AndroidAsyncTask
andAsyncTask
classes have been merged,as we don't need both levels of abstraction.
Microsoft.Android.Build.BaseTasks-Tests
has been updated to targetnet8.0 as I noticed the tests were no longer running: