Skip to content

[BaseTasks] Import Xamarin.Build.AsyncTask #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

pjcollins
Copy link
Member

@pjcollins pjcollins commented Jun 11, 2024

We've decided to move https://github.com/xamarin/Xamarin.Build.AsyncTask
into this repository as part of dotnet org migration efforts.

Source and test content from xamarin/Xamarin.Build.AsyncTask@db4ce14dac
has been added to Microsoft.Android.Build.BaseTasks.

The AndroidAsyncTask and AsyncTask classes have been merged,
as we don't need both levels of abstraction.

Microsoft.Android.Build.BaseTasks-Tests has been updated to target
net8.0 as I noticed the tests were no longer running:

/Users/runner/hostedtoolcache/dotnet/dotnet test /Users/runner/work/1/s/bin/TestDebug-net6.0/Microsoft.Android.Build.BaseTasks-Tests.dll --logger trx --results-directory /Users/runner/work/_temp
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
No test is available in /Users/runner/work/1/s/bin/TestDebug-net6.0/Microsoft.Android.Build.BaseTasks-Tests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

We've decided to move https://github.com/xamarin/Xamarin.Build.AsyncTask
into this repository as part of dotnet org migration efforts.

Source and test content from xamarin/Xamarin.Build.AsyncTask@db4ce14dac
has been added to Microsoft.Android.Build.BaseTasks.
@pjcollins
Copy link
Member Author

@pjcollins pjcollins requested a review from jonpryor June 25, 2024 20:58
@pjcollins pjcollins marked this pull request as ready for review June 25, 2024 20:58
@pjcollins
Copy link
Member Author

pjcollins commented Jun 25, 2024

@dellis1972 @jonathanpeppers I think this should be ready for further review and hopefully good to go now. I just bumped Microsoft.Android.Build.BaseTasks-Tests to .NET 8 as I noticed those tests weren't actually running in main:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=9730201&view=logs&j=3b059b26-55fe-5273-567a-5b3fa6c051e7&t=73552669-1d50-5779-0733-0594204b4f2d&l=16

/Users/runner/hostedtoolcache/dotnet/dotnet test /Users/runner/work/1/s/bin/TestDebug-net6.0/Microsoft.Android.Build.BaseTasks-Tests.dll --logger trx --results-directory /Users/runner/work/_temp
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
No test is available in /Users/runner/work/1/s/bin/TestDebug-net6.0/Microsoft.Android.Build.BaseTasks-Tests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

The downstream PRs are all looking good so far against these latest changes as well.

Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The main fallout will be bumping a lot of things everywhere!

@pjcollins pjcollins merged commit 3debf8e into main Jun 27, 2024
4 checks passed
@pjcollins pjcollins deleted the dev/pjc/import-asynctask branch June 27, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants