Update OpenJDK location for OpenJDK17 on windows #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tondat
commented
Sep 19, 2023
tondat
commented
- VS installer start using a zip payload to install the OpenJDK on %programFiles%/Android/openjdk/jdk-*
- VS installer start using a zip payload to install the OpenJDK on %programFiles%/Android/openjdk/jdk-*
MSLukeWest
approved these changes
Sep 19, 2023
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Sep 20, 2023
Changes: dotnet/android-tools@52f0866...8a971d9 * dotnet/android-tools@8a971d9: Merge pull request dotnet/android-tools#217 from xamarin/dev/tondat/main-openjdkms * dotnet/android-tools@42bbef8: Update OpenJDK location for OpenJDK17 on windows * dotnet/android-tools@9c50a2d: [build] set `$(DisableTransitiveFrameworkReferenceDownloads)`=true (dotnet/android-tools#216) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Sep 29, 2023
Changes: dotnet/android-tools@9c50a2d...8a971d9 * dotnet/android-tools@8a971d9: Merge pull request dotnet/android-tools#217 from xamarin/dev/tondat/main-openjdkms * dotnet/android-tools@42bbef8: Update OpenJDK location for OpenJDK17 on windows Adds support to look for JDK installation on Windows within `%ProgramFiles%\Android\openjdk\jdk-*`. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.