Skip to content

StrongName Microsoft.Android.Build.BaseTasks #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2021

Conversation

dellis1972
Copy link
Contributor

@dellis1972 dellis1972 commented Jul 19, 2021

Let's StrongName our assemblies.

@@ -4,11 +4,13 @@
<Import Project="..\tools\BuildTasks.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFrameworks>netstandard2.0;netcoreapp3.1</TargetFrameworks>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do this to work around

error CS1705: Assembly 'Microsoft.Android.Build.BaseTasks' with identity 'Microsoft.Android.Build.BaseTasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' uses 'libZipSharp, Version=1.0.7866.25205, Culture=neutral, PublicKeyToken=276db85bc4e20efc' which has a higher version than referenced assembly 'libZipSharp' with identity 'libZipSharp, Version=1.0.7866.25201, Culture=neutral, PublicKeyToken=276db85bc4e20efc'

Which is odd. But 🤷

@jonathanpeppers jonathanpeppers merged commit 87acd6b into dotnet:main Jul 19, 2021
@dellis1972 dellis1972 deleted the asynctask0.4.0 branch July 19, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants