[Xamarin.Android.Tools.AndroidSdk] Probe for Microsoft OpenJDK dirs #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
force-pushed
the
jonp-check-msjdk-dirs
branch
from
cb01ba5 to
01ed56b
Compare
mcumming
suggested changes
Mar 19, 2021
|
|
||
| static IEnumerable<string> GetMacOSMicrosoftOpenJdkPaths () | ||
| { | ||
| var jdk = AppDomain.CurrentDomain.GetData ($"GetMacOSMicrosoftOpenJdkPath override! {typeof (JdkInfo).AssemblyQualifiedName}") |
jonpryor
force-pushed
the
jonp-check-msjdk-dirs
branch
6 times, most recently
from
2a32fd3 to
1a29cf3
Compare
grendello
approved these changes
Mar 24, 2021
| @@ -139,9 +140,89 @@ internal static class RegistryEx | |||
| static extern int RegCreateKeyEx (UIntPtr hKey, string subKey, uint reserved, string? @class, uint options, | |||
| uint samDesired, IntPtr lpSecurityAttributes, out UIntPtr phkResult, out Disposition lpdwDisposition); | |||
|
|
|||
| // https://docs.microsoft.com/en-us/windows/win32/api/winreg/nf-winreg-regenumkeyexw | |||
| [DllImport (ADVAPI, CharSet = CharSet.Unicode, SetLastError = true)] | |||
| static extern int RegEnumKeyExW ( | |||
There was a problem hiding this comment.
What is the need for p/invoke here? Is it an issue with 32-bit processes reading 64-bit keys?
There was a problem hiding this comment.
I'm not sure of the original need; this code never used Microsoft.Win32.Registry & co, and I'm not sure why. (Apparently a question for @mhutch?)
Thus, given that we're already a tangled mess of P/Invokes, I figured it "best" to continue with the current paradigm.
jonpryor
force-pushed
the
jonp-check-msjdk-dirs
branch
from
1a29cf3 to
4c041c8
Compare
Context: https://aka.ms/getopenjdk Context: https://devblogs.microsoft.com/java Remove support for the obsolete (and never updated) `microsoft_dist_openjdk_*` builds of OpenJDK. Despite having "microsoft" in the name, it was maintained by a different team which has moved on to other things.
jonpryor
force-pushed
the
jonp-check-msjdk-dirs
branch
from
4c041c8 to
21ea061
Compare
jonathanpeppers
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.