- 
                Notifications
    
You must be signed in to change notification settings  - Fork 64
 
Update Gradle and Android Plugins #1244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this to recommend JDK 21?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See dotnet/android@e517d53 on why we should keep targeting Java 1.8 for Java source code.
We want to avoid:
Invoke-customs are only supported starting with Android O (--min-api 26)
        
          
                source/com.google.android.material/material.extensions/extensions-aar/build.gradle
          
            Show resolved
            Hide resolved
        
              
          
                source/com.google.android.play/asset.delivery.extensions/extensions-aar/build.gradle
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                source/com.google.android.play/core.extensions/extensions-aar/build.gradle
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks OK now, as long as CI is green!
| 
           This broke CI on macOS on DevDiv: But it worked on the public CI machines (those are dnceng).  | 
    
We can now use a modern Java to build the native libraries.