- 
                Notifications
    You must be signed in to change notification settings 
- Fork 63
Fix typo in MediaLibraryService method name: OnGetSeesionFromMediaLibraryService -> OnGetSessionFromMediaLibraryService #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…raryService -> OnGetSessionFromMediaLibraryService Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the nugetVersion to 1.7.1.1?
Lines 1361 to 1367 in 4d4739d
| { | |
| "groupId": "androidx.media3", | |
| "artifactId": "media3-session", | |
| "version": "1.7.1", | |
| "nugetVersion": "1.7.1", | |
| "nugetId": "Xamarin.AndroidX.Media3.Session" | |
| }, | 
Leave version as-is.
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
| 
 Updated the nugetVersion for media3-session from 1.7.1 to 1.7.1.1 in config.json. The version field remains unchanged as requested. 60862b0 | 
| The customer reports a second issue that is still happening: The file in question has the method: 	public androidx.media3.session.MediaSession onGetSession (androidx.media3.session.MediaSession.ControllerInfo p0)
	{
		return n_onGetSession (p0);
	}
	private native androidx.media3.session.MediaSession n_onGetSession (androidx.media3.session.MediaSession.ControllerInfo p0);We think this is caused by: android-libraries/source/androidx.media3/media3-session/Transforms/Metadata.xml Lines 56 to 67 in 179d214 
 Remove these, and see if we can solve the problem a different way. | 
…ediaLibraryService.onGetSession Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
| 
 Removed the problematic  | 
…rvice` typo (#1198) Fixes: #1195 Fixed a typo in the managedName attribute for the `MediaLibraryService.onGetSession` method binding where "Session" was misspelled as "Seesion". This was causing build errors when developers tried to override the method with the correct spelling. ## Problem When developers attempted to override the `OnGetSessionFromMediaLibraryService` method (with correct spelling), they would get Java errors during build. However, using the misspelled version `OnGetSeesionFromMediaLibraryService` would compile but not build properly. ## Solution - Changed `OnGetSeesionFromMediaLibraryService` to `OnGetSessionFromMediaLibraryService` in `/source/androidx.media3/media3-session/Transforms/Metadata.xml` - This is a minimal, single-character fix that corrects the typo without affecting any other functionality - Removed the problematic `managedReturn` and `managedOverride` attributes from lines 56-67 in Metadata.xml. These were forcing the `onGetSession` method to return `MediaSession` instead of the correct `MediaLibrarySession` type, causing the Java compatibility errors. Now developers can properly override the method using the correct spelling: ```csharp public override MediaLibrarySession OnGetSessionFromMediaLibraryService(MediaSession.ControllerInfo controllerInfo) { // Implementation } ```
Fixed a typo in the managedName attribute for the
MediaLibraryService.onGetSessionmethod binding where "Session" was misspelled as "Seesion". This was causing build errors when developers tried to override the method with the correct spelling.Problem
When developers attempted to override the
OnGetSessionFromMediaLibraryServicemethod (with correct spelling), they would get Java errors during build. However, using the misspelled versionOnGetSeesionFromMediaLibraryServicewould compile but not build properly.Solution
OnGetSeesionFromMediaLibraryServicetoOnGetSessionFromMediaLibraryServicein/source/androidx.media3/media3-session/Transforms/Metadata.xmlVerification
dotnet cake --target=metadata-verifyNow developers can properly override the method using the correct spelling:
Fixes #1195.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.