-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Move second batch of GPS package-specific templates to AndroidX defa…
…ult template. (#950) Move the packages in GPS that use the following package-specific templates to this repository and switch them to using the default template: - brotli - chromium-cronet - codehaus-mojo - datatransport - flatbuffers - grpc - opencensus - perfmark - protobuf-lite - squareup-okhttp - squareup-okhttp3 - squareup-picasso - squareup-retrofit - squareup-retrofit2 - squareup-okio - squareup-javapoet - tensorflow-lite - user-messaging-platform - zxing One wrinkle is that AndroidX does not allow a stable package to depend on a prerelease package: ```xml <!-- Warnings we want to error on: --> <!-- NU5104: A stable release of a package should not have a prerelease dependency. --> <WarningsAsErrors>$(WarningsAsErrors);NU5104</WarningsAsErrors> ``` Although we should always abide by this rule, we are bound by Google's packaging decisions and sometimes we have no choice. The `Xamarin.TensorFlow.Lite.Support.Api` and `Xamarin.TensorFlow.Lite.Task.Vision.PlayServices.Library` packages we are moving from GPS have a prerelease dependency. (GPS repository does not enforce this rule.) In order to keep this rule globally, but allow packages to opt out of it, add the `allowPrereleaseDependencies` artifact-level field to `config.json`: ```json { "groupId": "org.tensorflow", "artifactId": "tensorflow-lite-task-vision-play-services", "version": "0.4.4", "nugetVersion": "0.4.4.6", "nugetId": "Xamarin.TensorFlow.Lite.Task.Vision.PlayServices.Library", "allowPrereleaseDependencies": true, "comments": "Depends on Xamarin.Google.Android.ODML.Image which only has a prerelease version.", ... } ``` Companion PR that removes these packages from GPS: xamarin/GooglePlayServicesComponents#906
- Loading branch information
Showing
78 changed files
with
6,302 additions
and
116 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.