Skip to content

Conversation

mvphelps
Copy link
Contributor

Fixed, thanks @NiklasGustafsson I'll remember this in the future. I assume no need to update release notes on this one.

@NiklasGustafsson NiklasGustafsson merged commit 7d06a1d into dotnet:main Oct 23, 2024
2 checks passed
@NiklasGustafsson
Copy link
Contributor

Merged and released.

@mvphelps
Copy link
Contributor Author

@NiklasGustafsson does that mean I should see it on nuget.org? I don't see it, and readme still shows v0.103.0. Also the latest build looks like it did complete the native build but skipped cuda packaging, and didn't push packages: https://dotnet.visualstudio.com/TorchSharp/_build/results?buildId=110856&view=results

@NiklasGustafsson
Copy link
Contributor

NiklasGustafsson commented Oct 23, 2024

Once it's indexed by NuGet, you will see it.

The backends are only built and pushed when there's a new version of libtorch to integrate with.

@mvphelps
Copy link
Contributor Author

Ok that's the patience thing I'm working on. Got it. I'll check tomorrow!

@NiklasGustafsson
Copy link
Contributor

Ok that's the patience thing I'm working on. Got it. I'll check tomorrow!

Not that long. Give it another 20-30 minutes.

@NiklasGustafsson
Copy link
Contributor

Aha! Certificate problem holding it up...

@NiklasGustafsson
Copy link
Contributor

Available on NuGet now.

@mvphelps
Copy link
Contributor Author

@NiklasGustafsson

  1. Am now using the new scope changes with packed sequences. Working great!
  2. I appreciate your quick responses and good code review feedback. Being the PR guy can be thankless sometimes, so THANK YOU!

@NiklasGustafsson
Copy link
Contributor

It's the opposite of thankless when community members send PRs my way... :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants