-
Notifications
You must be signed in to change notification settings - Fork 201
torch.linalg.vector_norm
: Set ord
default as specified in docs
#1383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
torch.linalg.vector_norm
: Set ord
default as specified in docs
#1383
Conversation
@dotnet-policy-service agree company="Digitec Galaxus" |
Failing test looks - at first glance - not to be related to the commited change. |
this test also failed in #1376 , but it doesn't occur on my machine, a bit strange. |
hmm... i've tried all the possible combinations, win+core+cpu, win+core+gpu, win+framework+cpu, win+framework+gpu by the way it also failed on other platforms in #1376 perhaps it's related to the gpu or cuda version, and does not appear every time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the way you might also edit REALEASENOTES.md
for this
Sure. Just pushed the adapted releasenotes. I assumed the next release is going to be a patch, and classified the change as bug. |
@MiWeiss -- thanks for the contribution. I'll take a look later today. |
The next release will be a patch. I'm waiting for some more engineering resources to start helping out with TorchSharp, and then I'll use a couple of bugs as concrete work items to help introduce them to the code base. If this is essential, we can always do a quick release before then. |
There are some CI/CD instabilities. The machines we use to build with are inexpensive and often have trouble with resourcing. I rerun jobs all the time, and things usually go better with no changes to the PRs. |
The merged build is failing because of some error in package signing, which has nothing to do with the PR. |
The docs of this method specify:
Said default was however not actually implemented