Clean up AAsyncCallContext and SqlDataReader #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRahnama
reviewed
Feb 22, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlDataReader.cs
Show resolved
Hide resolved
Wraith2
force-pushed
the
dev-mergeasyncallscontexts
branch
from
10d2f76 to
404c88b
Compare
Merged
DavoudEshtehari
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
The class definition is in contrast with document. According to the design, my guess is the document should update.
|
About inheritance? Yes, it does seem to say that it can't be inherited. In this case since we don't intend to provide any kind of extensibility and users could serious screw up their data or programs by tinkering with things that they shouldn't I think sealing it might be a good idea. It is a breaking change though. |
johnnypham
approved these changes
Jun 16, 2021
@DavoudEshtehari We can make a separate PR to address this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking though #921 I realized that I hadn't got around to merging the SqlDataReader.AAsyncCallContext class with the top level one that I later derived from it. So I did that. I've cleaned up the inheritance and made the relationships between the classes and the functions that use them a little clearer with some comments so hopefully others will find it less confusing.
There's a small change in GetFieldValueAsync to use a static delegate that already existed rather than allocating a lambda. This will have a minor memory improvement.
I'm still looking for a good way of caching the async call context for GetFieldValueAsync but that will wait for a future PR.