Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX | Removing BinaryFormatter from NetFx #869

Merged
merged 14 commits into from
Feb 18, 2021
Merged

FIX | Removing BinaryFormatter from NetFx #869

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
68bce5a
Removing BinaryFormatter from NetFx
Jan 7, 2021
910ffed
Merge branch 'master' of https://github.com/dotnet/SqlClient into Rem…
Jan 19, 2021
316c036
review comments
Jan 21, 2021
4f22171
fix version typo
Jan 21, 2021
8ede142
remove extra line
Jan 21, 2021
8df3fcf
Reverted SqlException Test
Jan 21, 2021
cc0aca0
review comments
Jan 21, 2021
fe12461
Review comment
Jan 26, 2021
c93ca0a
Desrialize
Jan 29, 2021
b613194
addressing review comments
Feb 8, 2021
a4dc381
Fix exception in deserialization (#1)
karinazhou Feb 16, 2021
233b8fe
review comments
Feb 18, 2021
44a9144
add extra line to the end of strings designer
Feb 18, 2021
688091b
end of line
Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove extra line
  • Loading branch information
jJRahnama committed Jan 21, 2021
commit 8ede1425c6d3375e611f3ff893f237c365504826
2 changes: 0 additions & 2 deletions src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlDependency.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ private static void InvokeCallback(object eventContextPair)
// END EventContextPair private class.
// ----------------------------------------

JRahnama marked this conversation as resolved.
Show resolved Hide resolved

//-----------------------------------------------
// Private Class to add ObjRef as DataContract
//-----------------------------------------------
Expand Down Expand Up @@ -1317,7 +1316,6 @@ private void AddCommandInternal(SqlCommand cmd)
{
if (cmd != null)
{
// Don't bother with BID if command null.
long scopeID = SqlClientEventSource.Log.TryNotificationScopeEnterEvent("<sc.SqlDependency.AddCommandInternal|DEP> {0}, SqlCommand: {1}", ObjectID, cmd.ObjectID);
try
{
Expand Down