Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 688 AsyncHelper.WaitForCompletion leaks unobserved exceptions #692

Merged
merged 13 commits into from
Oct 22, 2020
Merged

Issue 688 AsyncHelper.WaitForCompletion leaks unobserved exceptions #692

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ad763b8
Create an example of how TaskHelper.WaitForCompletion leaks unobserve…
Aug 13, 2020
c4d6ed2
Use internalsvisibleto rather than making things public
Aug 13, 2020
2618c65
Tidy up pre PR
Aug 14, 2020
60cea01
Add more detailed info on the unhandled exception to diagnose build f…
Aug 14, 2020
4a8b3e9
Patch fix to netfx version of SqlUtil too
Aug 14, 2020
3b09392
Stop other unit tests from leaving unobserved exceptions
Aug 15, 2020
a2ea136
Leak even fewer unobserved exceptions
Aug 15, 2020
fc09c96
Merge branch 'master' into UnobservedExceptionPR
Sep 1, 2020
08b54d4
View the exception from the continuation
Sep 1, 2020
f3aed3b
Observe the exception from _the other_ SqlUtil
Sep 1, 2020
07ad6ec
Swap lambda to local function
jm771 Sep 1, 2020
c350827
Merge https://github.com/dotnet/SqlClient into UnobservedExceptionPR
jm771 Oct 21, 2020
04ac97f
Merge branch 'UnobservedExceptionPR' of https://github.com/jm771/SqlC…
jm771 Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge https://github.com/dotnet/SqlClient into UnobservedExceptionPR
  • Loading branch information
@jm771
jm771 committed Oct 21, 2020
commit c350827dc22fa53d9eeb124951ffb39fc27a9867

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.