Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change that made SqlDataReader.ReadAsync() non-blocking #547

Merged
merged 10 commits into from
May 1, 2020
Merged

Revert change that made SqlDataReader.ReadAsync() non-blocking #547

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fee80d0
Fix stored procedure issues
cheenamalhotra Apr 27, 2020
7cb481d
Fix comment
cheenamalhotra Apr 27, 2020
3dfc06a
Add test case.
cheenamalhotra Apr 28, 2020
3cea037
Handle test case for named pipes
cheenamalhotra Apr 28, 2020
5428ec5
Added more test cases
cheenamalhotra Apr 28, 2020
4229fcc
Skip on Azure
cheenamalhotra Apr 28, 2020
68782c6
Typo
cheenamalhotra Apr 28, 2020
9a2ae1b
Small Sleep time
cheenamalhotra Apr 28, 2020
9511693
Fix issue by original change revert.
cheenamalhotra Apr 29, 2020
a7f5949
Add comment
cheenamalhotra Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Small Sleep time
  • Loading branch information
@cheenamalhotra
cheenamalhotra committed Apr 28, 2020
commit 9a2ae1bb32db935987ec114c26761a5eb7cd5f07
3 changes: 2 additions & 1 deletion src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandCancelTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,8 @@ IF EXISTS (SELECT name FROM msdb.dbo.sysalerts WHERE name = N'{alertName}')
{
retry = true;
retryAttempt++;
Console.WriteLine($"Retry Attempt : {retryAttempt}");
Console.WriteLine($"CancelFollowedByAlert Test retry attempt : {retryAttempt}");
Thread.Sleep(500);
continue;
}
}
Expand Down