Repository navigation
Conversation
+Comments
+Comments
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The parser-wide refactor spans 28 files, and its build and test checks were still incomplete during review.
0 open findings
What changed in this PR
Normalizes internal TDS metadata types without intended public API or behavioral changes.
Changes:
- Replaces legacy metadata classes with consistently named
Tds*types. - Converts eligible fields to documented properties and updates dependent call sites.
- Updates metadata and bulk-copy unit tests.
| File | Description |
|---|---|
Connection/ServerInfo.cs |
Uses normalized routing metadata. |
Connection/SqlConnectionInternal.cs |
Updates routing and federated-auth token handling. |
Parser/TdsParser.cs |
Migrates token parsing and serialization to the new model. |
Parser/TdsParserStateObject.cs |
Updates parser cleanup metadata types. |
Parser/Tokens/RoutingInfo.cs |
Removes the legacy routing type. |
Parser/Tokens/SqlFedAuthInfo.cs |
Removes the legacy federated-auth type. |
Parser/Tokens/SqlMetaDataPriv.cs |
Removes the legacy base metadata type. |
Parser/Tokens/SqlReturnValue.cs |
Removes the legacy return-value type. |
Parser/Tokens/TdsAltMetadataCollection.cs |
Adds normalized alternate metadata storage. |
Parser/Tokens/TdsColumnMetadata.cs |
Adds normalized per-column metadata. |
Parser/Tokens/TdsColumnMetadataToken.cs |
Adds normalized column-metadata tokens. |
Parser/Tokens/TdsEnvChangeRoutingInfo.cs |
Adds normalized routing information. |
Parser/Tokens/TdsFedAuthInfoToken.cs |
Adds the federated-auth token model. |
Parser/Tokens/TdsReturnValueToken.cs |
Adds the return-value token model. |
Parser/Tokens/TdsTableName.cs |
Renames and documents multipart table metadata. |
Parser/Tokens/TdsTypeInfo.cs |
Adds the normalized base type-information model. |
Parser/Tokens/_SqlMetaData.cs |
Removes legacy column metadata. |
Parser/Tokens/_SqlMetaDataSet.cs |
Removes the legacy metadata set. |
Parser/Tokens/_SqlMetaDataSetCollection.cs |
Removes the legacy alternate metadata collection. |
SqlBulkCopy.cs |
Migrates bulk-copy metadata usage. |
SqlCachedBuffer.cs |
Updates cached-buffer type metadata. |
SqlCommand.cs |
Migrates command and return-value metadata. |
SqlConnection.cs |
Updates UDT helpers to normalized metadata. |
SqlDataReader.cs |
Migrates reader and schema metadata handling. |
SqlDbColumn.cs |
Uses normalized column metadata properties. |
SqlEnvChange.cs |
Uses normalized routing information. |
SqlBulkCopyVariantTests.cs |
Updates variant metadata test setup. |
SqlMetaDataSetTest.cs |
Updates metadata cloning tests. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Normalizes internal TDS token metadata names so each type clearly identifies the protocol token or metadata concept it represents.
Sql*and underscore-prefixed metadata types to consistentTds*names.This is layer 2 of 3 in the TDS parser organization stack. It targets
dev/russellben/tds-groups(PR #4810), so review should focus on this PR's token-model changes rather than the parser moves in the preceding layer.Issues
Supersedes closed PR #4676. No linked issue; this is an internal naming and maintainability refactor.
Testing
Existing metadata and other affected test sources are updated for the normalized token model. No new test run was performed during PR submission.
Guidelines
Tests added or updated
Public API changes documented (not applicable; no public API change intended)
Verified against customer repro (not applicable)
Ensure no breaking changes introduced
Contributing
Code of Conduct
Best Practices
Coding Style
Review Process