Repository navigation
Localize authentication and pool validation error messages - #4805
Draft
cheenamalhotra wants to merge 1 commit into
Draft
cheenamalhotra wants to merge 1 commit into
cheenamalhotra wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3d81d79a-b106-4b45-977e-28dc76b9507d
cheenamalhotra
requested review from
a team
and
a balanced review from Copilot
October 7, 2026 21:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The resource extraction preserves wording and exception metadata with focused cross-assembly regression coverage.
0 open findings
What changed in this PR
Moves authentication, token, and pool validation errors into assembly-owned resources while preserving behavior and exception metadata.
Changes:
- Added localized resource infrastructure for Azure and Abstractions extensions.
- Replaced hard-coded validation/authentication messages with typed resources.
- Added regression tests, documentation, and review guidance.
| File | Description |
|---|---|
PoolValidationResourceTest.cs |
Tests pool validation resources and metadata. |
Strings.resx (SqlClient) |
Adds pool validation messages. |
Strings.Designer.cs |
Adds typed pool resource accessors. |
DbConnectionPoolOptions.cs |
Uses the idle-timeout resource. |
ConnectionPoolSlots.cs |
Uses capacity validation resources. |
WamBrokerTests.cs |
Tests framework-specific callback errors. |
AuthorityParsingTests.cs |
Verifies localized authority errors. |
AuthenticationResourceTests.cs |
Tests Azure resources and exception metadata. |
Azure/src/Resources/Strings.resx |
Defines Azure authentication messages. |
Azure.csproj |
Configures strongly typed resources. |
AuthenticationException.cs |
Localizes authentication wrappers. |
ActiveDirectoryAuthenticationProvider.Windows.cs |
Localizes invalid callback errors. |
ActiveDirectoryAuthenticationProvider.cs |
Localizes provider errors. |
SqlAuthenticationTokenTest.cs |
Tests token resource fallback. |
SqlAuthenticationToken.cs |
Uses the token validation resource. |
Abstractions/src/Resources/Strings.resx |
Defines token validation text. |
Abstractions.csproj |
Configures strongly typed resources. |
Abstractions/README.md |
Documents localization ownership. |
sqlclient-code-review/SKILL.md |
Adds localization review guidance. |
driver-checks.md |
Defines user-facing string checks. |
Files not reviewed (1)
- src/Microsoft.Data.SqlClient/src/Resources/Strings.Designer.cs: Generated file
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cheenamalhotra
marked this pull request as draft
October 7, 2026 22:02
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the authority error from #4521, related authentication messages and wrappers, token validation, and pool validation errors into owning-assembly resources.
Preserve English wording and exception metadata. No public API changes or translations are added. Add regression tests and localization guidance, and update the code-review skill to flag hard-coded user-facing messages.
Issues
Related to #4521.
Testing
Guidelines