Skip to content

Use the source-generated JSON context in HGS MakeRequestAsync - #4801

Merged
cheenamalhotra merged 1 commit into
dotnet:mainfrom
virzak:dev/automation/hgs-async-json-context
Oct 8, 2026
Merged

cheenamalhotra merged 1 commit into
dotnet:mainfrom
virzak:dev/automation/hgs-async-json-context

Conversation

@virzak

@virzak virzak commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

HostGuardianServiceEnclaveProvider.MakeRequestAsync deserializes with reflection, which raises IL2026 and IL3050. The sync MakeRequest already uses SqlClientJsonSerializerContext.Default.ListByte; the async path now does too.

Part of #1947. Raised in the triage of #4799.

Testing

  • Trim/AOT analyzer on net8.0: both errors in VirtualSecureModeEnclaveProvider.cs gone.
  • Enclave unit tests pass on net8.0 and net462.

@virzak
virzak requested a review from a team as a code owner October 7, 2026 12:07
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@cheenamalhotra cheenamalhotra added this to the 8.0.0-preview1 milestone Oct 7, 2026
@charlesroddie

Copy link
Copy Markdown
Contributor

This PR is good. It completes #4683, which missed this as MakeRequestAsync was added in #4541 after it was created.

@cheenamalhotra

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.

@cheenamalhotra
cheenamalhotra merged commit 332e17f into dotnet:main Oct 8, 2026
125 of 130 checks passed
@virzak
virzak deleted the dev/automation/hgs-async-json-context branch October 9, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants