Skip to content

Backport official US English locale name to 7.1 - #4657

Closed
priyankatiwari08 wants to merge 1 commit into
dotnet:release/7.1-stagingfrom
priyankatiwari08:priyankatiwari08-backport-language-name-7-1
Closed

priyankatiwari08 wants to merge 1 commit into
dotnet:release/7.1-stagingfrom
priyankatiwari08:priyankatiwari08-backport-language-name-7-1

Conversation

@priyankatiwari08

Copy link
Copy Markdown
Contributor

Backports #4646 for Azure DevOps task 45863. This is a docs-only, one-line correction that uses the official US English locale name.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 8, 2026 07:25
@priyankatiwari08
priyankatiwari08 requested a review from a team as a code owner September 8, 2026 07:25
@github-project-automation github-project-automation Bot moved this to To triage in SqlClient Board Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The one-line documentation correction matches the stated requirement without affecting behavior or APIs.

Pull request overview

Corrects the LCID 1033 documentation snippet to use the official US English locale name.

Changes:

  • Replaces English - United States with English (United States).
File summaries
File Description
doc/snippets/Microsoft.Data.SqlClient/SqlParameter.xml Corrects the locale name in a documentation comment.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@priyankatiwari08 priyankatiwari08 added this to the 7.1.0 milestone Sep 8, 2026
@github-project-automation github-project-automation Bot moved this from To triage to Done in SqlClient Board Sep 8, 2026
@github-project-automation github-project-automation Bot moved this from Done to Backlog in SqlClient Board Sep 8, 2026
@priyankatiwari08

Copy link
Copy Markdown
Contributor Author

Backport validation note: milestone 7.1.0 is assigned and the PR intentionally targets the current GA integration branch,
elease/7.1-staging. The milestone check derives
elease/7.1\ from the milestone and therefore does not recognize the -staging\ branch name. The diff remains the verified one-line documentation correction from #4646.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/7.1-staging@faa131e). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                   @@
##             release/7.1-staging    #4657   +/-   ##
======================================================
  Coverage                       ?   64.34%           
======================================================
  Files                          ?      284           
  Lines                          ?    67980           
  Branches                       ?        0           
======================================================
  Hits                           ?    43744           
  Misses                         ?    24236           
  Partials                       ?        0           
Flag Coverage Δ
PR-SqlClient-Project 64.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski

Copy link
Copy Markdown
Contributor

No need for 7.1 staging backports - I will sync the branch from main after the code freeze.

@github-project-automation github-project-automation Bot moved this from Backlog to Done in SqlClient Board Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants