Skip to content

Fixing NullReferenceException issue with SqlDataAdapter #3857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyankatiwari08 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Fixing NullReferenceException issue with SqlDataAdapter #3857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.Encryption.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ private SqlDataReader TryFetchInputParameterEncryptionInfo(
// not present as the rpcName, as is the case with non-_batchRPCMode. So
// input parameters start at parameters[1]. parameters[0] is the actual
// T-SQL Statement. rpcName is sp_executesql.
if (_RPCList[i].systemParams.Length > 1)
if (_RPCList[i].systemParams != null && _RPCList[i].systemParams.Length > 1)
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The null check added here is correct and necessary to prevent NullReferenceException in batch scenarios. However, there doesn't appear to be a test case that covers this specific scenario - batching with Always Encrypted where systemParams could be null. Consider adding a test that exercises this code path to prevent regression.

Copilot uses AI. Check for mistakes.
{
_RPCList[i].needsFetchParameterEncryptionMetadata = true;

Expand Down
Loading