Test | Kill tests that run longer than 5 mins. #3832
Draft
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a 5-minute timeout to all test executions to handle poorly designed tests, resource contention, and deadlock scenarios. The --blame-hang-timeout 5m flag causes tests to be aborted if they exceed the specified duration, enabling fail-fast behavior instead of consuming resources indefinitely.
Key Changes
- Added
--blame-hang-timeout 5mparameter to all test execution targets in build.proj - Applied consistently across unit, functional, and manual tests for both Windows and Unix platforms
Contributor
|
We can also consider an approach like this to get start/end logging, and per-test re-runs on hangs or transient failures: https://andrewlock.net/tracking-down-a-hanging-xunit-test-in-ci-building-a-custom-test-framework/ |
paulmedynski
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Poor test design and resource contention sometimes lead to test cases that run longer than desired. In other cases, tests are genuinely stuck due to deadlocks. In these situations, it's best to kill the test case and rerun. Unfortunately, because we use xunit2 and vstest, we're stuck with rerunning the whole test suite as there's no option to rerun only failing tests.
All the same tests are run, but they should now "fail fast" instead of sitting and consuming resources.
I'll leave this PR open for a bit and rerun the pipeline on it to see how useful this behavior is in practice.