-
Notifications
You must be signed in to change notification settings - Fork 319
[6.1] Fix code coverage job disk full #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR backports a fix from #3798 to the 6.1 branch to address disk space issues in code coverage jobs. The changes switch the code coverage job to use a custom 1ES image with more disk space, refactor parameter handling, add debug output for monitoring disk usage, and improve the overall structure of the code coverage template.
Key changes:
- Switched code coverage job to use
ADO-MMS22-CodeCovimage instead of generic Azure Pipelines image - Refactored code coverage job template with clearer parameter structure and inline artifact downloads
- Added debug steps throughout the job to monitor disk usage and help diagnose future space issues
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-ci-core.yml | Removed unused defaultHostedPoolName variable, updated code coverage job parameters to pass image, pool, and targetFrameworks directly, and changed hardcoded pool reference from variable to string literal |
| eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml | Comprehensive refactoring: added parameter documentation, moved artifact downloads inline, changed pool configuration to support both hosted and custom pools, added disk usage debug steps, improved cleanup logic with -ErrorAction SilentlyContinue, and changed upload condition from runtime variable to compile-time parameter |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3813 +/- ##
===============================================
- Coverage 65.27% 63.67% -1.61%
===============================================
Files 279 279
Lines 61765 53290 -8475
===============================================
- Hits 40319 33932 -6387
+ Misses 21446 19358 -2088
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Backport of #3798 to 6.1
The code coverage jobs are running out of disk space. They appear to consume upwards of 12GB of space to merge/convert 3GB of coverage logs from the various test jobs. We can diagnose why that is later. For now, I have: