-
Notifications
You must be signed in to change notification settings - Fork 317
[6.1] Update CI pipelines to trigger for PR, commits, and schedules #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/6.1
Are you sure you want to change the base?
Conversation
- Updating CI pipeline configs to be used for PR, Commit, and Schedule triggers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates two CI pipeline configurations to properly support PR validation, commit triggers, and scheduled runs with clearer separation and documentation. The changes standardize the trigger configurations across both the project reference and package reference pipelines.
- Separated PR triggers from commit triggers with distinct configurations and improved documentation
- Expanded path filters for PR triggers to include more relevant directories
- Added separate scheduled runs for GitHub and ADO branches with staggered execution times
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| eng/pipelines/dotnet-sqlclient-ci-project-reference-pipeline.yml | Restructured triggers to separate PR, commit, and schedule sections with enhanced path filters and dual scheduled runs |
| eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml | Restructured triggers to separate PR, commit, and schedule sections with enhanced path filters and dual scheduled runs |
eng/pipelines/dotnet-sqlclient-ci-project-reference-pipeline.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/dotnet-sqlclient-ci-project-reference-pipeline.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml
Outdated
Show resolved
Hide resolved
eng/pipelines/dotnet-sqlclient-ci-package-reference-pipeline.yml
Outdated
Show resolved
Hide resolved
- Addressed review comments.
|
@copilot Please resolve your comments if you are satisfied. |
|
@paulmedynski I've opened a new pull request, #3770, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@copilot That is not what I asked. Abandon your draft changes. Instead, please resolve your comments on this PR if you are satisfied that they have been addressed. |
|
@paulmedynski I've opened a new pull request, #3771, to work on those changes. Once the pull request is ready, I'll request review from you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3769 +/- ##
===============================================
- Coverage 66.69% 65.09% -1.61%
===============================================
Files 279 273 -6
Lines 61764 61448 -316
===============================================
- Hits 41192 39998 -1194
- Misses 20572 21450 +878
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
We have changed the Azure DevOps configuration for the CI-SqlClient and CI-SqlClient-Package pipelines. They no longer use Classic UI-based PR triggers. We now must use the YAML definitions to configure all trigger types (PR, Commit, Schedule).
This PR updates the two CI pipeline YAML definitions to configure PR, Commit, and Schedule triggers.