-
Notifications
You must be signed in to change notification settings - Fork 317
Merge | SqlConnectionHelper.cs #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge | SqlConnectionHelper.cs #3634
Conversation
This includes a rename of _connectionFactory to s_connectionFactory
This was only ever called by EnlistDistributedTransaction, so inlined
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Darn, I had just started on this one :( |
|
If it's any consolation, the merge is almost completely done (file-wise, at least.) When all other PRs are merged, the only file remaining will be SqlInternalConnectionTds.cs. I'm happy to leave that to you if you'd prefer - the diff is small, but publicly visible. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3634 +/- ##
==========================================
- Coverage 66.13% 60.05% -6.08%
==========================================
Files 276 268 -8
Lines 60765 60328 -437
==========================================
- Hits 40184 36228 -3956
- Misses 20581 24100 +3519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This removes the separate, largely duplicated SqlConnectionHelper.cs files. These files contained members of SqlConnection. I've moved the members in small groups in each commit, and recommend reviewing commit-by-commit for ease of review.
After the merge is done, it'd be good to organise large files like this more consistently; at the moment, it seems to simply group methods by their area of functionality. I've tried to maintain consistency here.
Issues
Relates to #1261.
Testing
Automated tests pass; I'd appreciate a CI run.