Skip to content

Conversation

@edwardneal
Copy link
Contributor

Description

This removes the separate, largely duplicated SqlConnectionHelper.cs files. These files contained members of SqlConnection. I've moved the members in small groups in each commit, and recommend reviewing commit-by-commit for ease of review.

After the merge is done, it'd be good to organise large files like this more consistently; at the moment, it seems to simply group methods by their area of functionality. I've tried to maintain consistency here.

Issues

Relates to #1261.

Testing

Automated tests pass; I'd appreciate a CI run.

@edwardneal edwardneal requested a review from a team as a code owner September 24, 2025 17:40
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@benrr101
Copy link
Contributor

Darn, I had just started on this one :(

@edwardneal
Copy link
Contributor Author

If it's any consolation, the merge is almost completely done (file-wise, at least.)

When all other PRs are merged, the only file remaining will be SqlInternalConnectionTds.cs. I'm happy to leave that to you if you'd prefer - the diff is small, but publicly visible.

@benrr101 benrr101 added the Common Project 🚮 Things that relate to the common project project label Sep 29, 2025
@benrr101 benrr101 added this to the 7.0-preview2 milestone Sep 29, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 69.29825% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.05%. Comparing base (37d8a3f) to head (a96b006).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...ient/src/Microsoft/Data/SqlClient/SqlConnection.cs 69.29% 35 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (37d8a3f) and HEAD (a96b006). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (37d8a3f) HEAD (a96b006)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3634      +/-   ##
==========================================
- Coverage   66.13%   60.05%   -6.08%     
==========================================
  Files         276      268       -8     
  Lines       60765    60328     -437     
==========================================
- Hits        40184    36228    -3956     
- Misses      20581    24100    +3519     
Flag Coverage Δ
addons ?
netcore 62.50% <80.21%> (-5.58%) ⬇️
netfx 64.30% <69.29%> (-5.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski merged commit 17045bc into dotnet:main Sep 30, 2025
236 checks passed
@edwardneal edwardneal deleted the merge/sqlconnectionhelper branch September 30, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Common Project 🚮 Things that relate to the common project project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants