-
Notifications
You must be signed in to change notification settings - Fork 317
[7.0] Fix package dependency versions #3614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Synchronized our actual and advertised package dependencies. - Made a few MDS official pipeline tweaks.
- Fixed AKV nuspec to be compatible with MDS 7.0.0 preview releases.
- Fixed AKV nuspec version for MDS to work for all 7.0.x versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes package dependency version inconsistencies between actual and advertised versions for Microsoft Data SqlClient (MDS) and Azure Key Vault (AKV) packages. The changes ensure dependency versions are current, accurate, and consistent across the project.
- Updates dependency version notation for AKV's nuspec to support all MDS 7.0.x versions including preview releases
- Fixes the GenerateAKVProviderNugetPackage target to include missing ReferenceType property
- Reorganizes Directory.Packages.props with clear categorization of package dependencies
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/targets/add-ons/GenerateAKVProviderNugetPackage.targets | Adds missing ReferenceType property to NuGet pack command |
| tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec | Updates dependency version ranges and adds net9.0 file entries |
| tools/specs/Microsoft.Data.SqlClient.nuspec | Updates package dependency versions and adds missing RuntimeInformation dependency |
| src/Directory.Packages.props | Reorganizes package versions with clear categorization and comments |
| eng/pipelines/dotnet-sqlclient-signing-pipeline.yml | Changes debug output default from true to false |
| eng/pipelines/common/templates/steps/publish-symbols-step.yml | Removes default value for publishSymbols parameter |
| .editorconfig | Consolidates XML file indent rules into single pattern |
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Show resolved
Hide resolved
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Outdated
Show resolved
Hide resolved
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Outdated
Show resolved
Hide resolved
paulmedynski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supplying commentary for reviewers.
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Show resolved
Hide resolved
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Show resolved
Hide resolved
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Outdated
Show resolved
Hide resolved
- Fixed AKV nuspec version for MDS to work for all 7.0.x versions.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3614 +/- ##
==========================================
+ Coverage 65.51% 69.57% +4.05%
==========================================
Files 277 271 -6
Lines 61686 61370 -316
==========================================
+ Hits 40416 42698 +2282
+ Misses 21270 18672 -2598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Outdated
Show resolved
Hide resolved
- Removed .NET 9.0 DLLs from AKV nuspec and suppressed associated warning.
- Removed .NET 9.0 DLLs from AKV nuspec and suppressed associated warning.
paulmedynski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More commentary.
Description
Once again, our actual and advertised MDS and AKV package dependencies have diverged. This cleans them up to be current, accurate, and consistent. I re-arranged the
Directory.Packages.propsfile to indicate where/why packages are used.I also managed to find a dependency version notation for AKV's .nuspec that allows it to be compatible with all MDS 7.0.x versions, including preview releases.
The
GenerateAKVProviderNugetPackagewasn't working, so I fixed that as well.I made some official pipeline tweaks as well after deleting some unused/obsolete pipeline variables.
Testing
Tested restoring MDS and AKV packages in a test project using their pre-release versioning to prove that NuGet is happy.