Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Description

Once again, our actual and advertised MDS and AKV package dependencies have diverged. This cleans them up to be current, accurate, and consistent. I re-arranged the Directory.Packages.props file to indicate where/why packages are used.

I also managed to find a dependency version notation for AKV's .nuspec that allows it to be compatible with all MDS 7.0.x versions, including preview releases.

The GenerateAKVProviderNugetPackage wasn't working, so I fixed that as well.

I made some official pipeline tweaks as well after deleting some unused/obsolete pipeline variables.

Testing

Tested restoring MDS and AKV packages in a test project using their pre-release versioning to prove that NuGet is happy.

- Synchronized our actual and advertised package dependencies.
- Made a few MDS official pipeline tweaks.
- Fixed AKV nuspec to be compatible with MDS 7.0.0 preview releases.
- Fixed AKV nuspec version for MDS to work for all 7.0.x versions.
@paulmedynski paulmedynski added this to the 7.0-preview1 milestone Sep 12, 2025
Copilot AI review requested due to automatic review settings September 12, 2025 15:28
@paulmedynski paulmedynski requested a review from a team as a code owner September 12, 2025 15:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes package dependency version inconsistencies between actual and advertised versions for Microsoft Data SqlClient (MDS) and Azure Key Vault (AKV) packages. The changes ensure dependency versions are current, accurate, and consistent across the project.

  • Updates dependency version notation for AKV's nuspec to support all MDS 7.0.x versions including preview releases
  • Fixes the GenerateAKVProviderNugetPackage target to include missing ReferenceType property
  • Reorganizes Directory.Packages.props with clear categorization of package dependencies

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/targets/add-ons/GenerateAKVProviderNugetPackage.targets Adds missing ReferenceType property to NuGet pack command
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec Updates dependency version ranges and adds net9.0 file entries
tools/specs/Microsoft.Data.SqlClient.nuspec Updates package dependency versions and adds missing RuntimeInformation dependency
src/Directory.Packages.props Reorganizes package versions with clear categorization and comments
eng/pipelines/dotnet-sqlclient-signing-pipeline.yml Changes debug output default from true to false
eng/pipelines/common/templates/steps/publish-symbols-step.yml Removes default value for publishSymbols parameter
.editorconfig Consolidates XML file indent rules into single pattern

Copy link
Contributor Author

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supplying commentary for reviewers.

- Fixed AKV nuspec version for MDS to work for all 7.0.x versions.
@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.57%. Comparing base (fe69ef4) to head (0b4d7df).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3614      +/-   ##
==========================================
+ Coverage   65.51%   69.57%   +4.05%     
==========================================
  Files         277      271       -6     
  Lines       61686    61370     -316     
==========================================
+ Hits        40416    42698    +2282     
+ Misses      21270    18672    -2598     
Flag Coverage Δ
addons ?
netcore 73.24% <ø> (+5.61%) ⬆️
netfx 68.31% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benrr101
benrr101 previously approved these changes Sep 12, 2025
- Removed .NET 9.0 DLLs from AKV nuspec and suppressed associated warning.
benrr101
benrr101 previously approved these changes Sep 12, 2025
- Removed .NET 9.0 DLLs from AKV nuspec and suppressed associated warning.
Copy link
Contributor Author

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More commentary.

@paulmedynski paulmedynski merged commit fd16c6d into main Sep 13, 2025
252 checks passed
@paulmedynski paulmedynski deleted the dev/paul/dependencies branch September 13, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants