Re-home stress test projects #3546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-homes stress test projects from Azure DevOps (ADO) into GitHub by adding comprehensive stress testing infrastructure for Microsoft.Data.SqlClient. The purpose is to consolidate testing tools and improve accessibility by moving stress tests to the main repository.
Key changes include:
- Addition of a complete stress testing framework with test harness and runner
- Implementation of SqlClient-specific stress tests covering async operations, MARS, and various command types
- Integration of monitoring and logging capabilities for test execution tracking
Reviewed Changes
Copilot reviewed 55 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| SqlClientStressTest.sln | Solution file defining the stress test project structure |
| SqlClient.Stress.Tests/* | Core SqlClient stress tests including async operations, MARS, and parameter tests |
| SqlClient.Stress.Runner/* | Test execution harness with threading, monitoring, and result logging |
| SqlClient.Stress.Framework/* | Base framework providing data access abstractions and test infrastructure |
| SqlClient.Stress.Common/* | Shared utilities and common test attributes |
| IMonitorLoader/* | Interface for test monitoring and metrics collection |
Comments suppressed due to low confidence (1)
benrr101
approved these changes
Aug 6, 2025
Contributor
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
Gonna close my eyes and just let this one go in as-is.
mdaigle
approved these changes
Aug 6, 2025
Member
There was a problem hiding this comment.
This file can be avoided, can you include these projects into the main solution under StressTests folder?
| This project intends to help finding a certain level of effectiveness under unfavorable conditions, and verifying the mode of failures. | ||
| This is a console application with targeting frameworks `.Net Framework 4.8`, `.NET 9.0` under driver's supported operating systems and SQL Servers. | ||
|
|
||
| ## Purpose of application for developers |
Member
There was a problem hiding this comment.
This heading and description can be removed.
cheenamalhotra
approved these changes
Aug 6, 2025
Member
There was a problem hiding this comment.
Approved with minor touch-ups needed. Feel free to address them in next PR @benrr101
mdaigle
reviewed
Aug 6, 2025
|
|
||
| private XmlReader CreateReader() | ||
| { | ||
| FileStream configurationStream = new FileStream("SqlClient.Stress.Framework/" + _configFilePath, FileMode.Open); |
Contributor
There was a problem hiding this comment.
I had to remove the prefix to get this to run:
Suggested change
| FileStream configurationStream = new FileStream("SqlClient.Stress.Framework/" + _configFilePath, FileMode.Open); | |
| FileStream configurationStream = new FileStream(_configFilePath, FileMode.Open); |
Contributor
There was a problem hiding this comment.
In the bin, the config file isn't nested under that directory.
benrr101
pushed a commit
that referenced
this pull request
Aug 8, 2025
(This code is effectively dead since it is not being referenced anywhere, and there are no other changes to the code. As such, we can bypass the one flaky test failure.)
paulmedynski
added a commit
that referenced
this pull request
Aug 14, 2025
(This code is effectively dead since it is not being referenced anywhere, and there are no other changes to the code. As such, we can bypass the one flaky test failure.)
paulmedynski
added a commit
that referenced
this pull request
Aug 28, 2025
* Moved existing stress test projects from ADO into GitHub. (#3546) (This code is effectively dead since it is not being referenced anywhere, and there are no other changes to the code. As such, we can bypass the one flaky test failure.) * Minimal modifications to stress tests for Linux (#3548) * Minimal modifications to get the stress tests building and running on Linux. * Updated sample config to avoid a dummy password. * User Story 38131: Stress Tests CI - Added config file path configuration via STRESS_CONFIG_FILE environment variable. - Added support for JSON config file. - Fixed process exit code to reflect success vs failure. - Added emission to console. - Added emission of data source. - Added EntraId password-based auth. - Added CI stage. - Added NuGet package version to MDS assembly. - Added dotnet build configuration pararmeter to CI entry points. - Added MDS package version configurability to stress tests. - Added all target frameworks that MDS supports. - Each test run now creates and drops its own database to avoid collisions. - Moved to 1ES images where possible. - Using a local SQL Server that we setup as part of CI. * User Story 38131: Stress Tests CI - Added top-level pipeline flag to enable stress tests, deafult is false until tests are reliably passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved existing stress test projects from ADO into GitHub.