[6.1] Update AKV to depend on any MDS 6.x package #3517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated AKV to depend on all MDS 6.x versions.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Key Vault (AKV) provider package to be compatible with any Microsoft.Data.SqlClient 6.x release by expanding the dependency version range. The change allows the AKV provider to work with the latest MDS 6.1.0 release and future 6.x versions.
- Updated dependency version range from
[6.0.1,6.1.0)to[6.0.1,7.0.0)for Microsoft.Data.SqlClient
mdaigle
previously approved these changes
Jul 25, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3517 +/- ##
================================================
- Coverage 90.82% 67.53% -23.29%
================================================
Files 6 281 +275
Lines 316 62401 +62085
================================================
+ Hits 287 42144 +41857
- Misses 29 20257 +20228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
previously approved these changes
Jul 25, 2025
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec
Show resolved
Hide resolved
paulmedynski
dismissed stale reviews from cheenamalhotra and mdaigle
via
cb86fce
- Changed AKV to depend on at least MDS 6.1.0.
cheenamalhotra
approved these changes
Jul 28, 2025
mdaigle
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #3516.
Updated the AKV .nuspec file to declare it depends on any MDS 6.x package. This will make it compatible with the latest MDS 6.1.0 release, and any future MDS 6.x releases.