[6.1] Revert recent AKV URL changes #3507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1ccdf40.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes from PR #3486 related to Azure Key Vault (AKV) URL validation. The revert removes recent AKV URL changes and restores the previous implementation.
- Removes the
TrustedUrlsTest.csfile that was added for testing AKV URL validation - Restores inline error message validation in
ExceptionTestAKVStore.csinstead of using the removed test class - Reduces the list of trusted Azure Key Vault domain names from 12 to 8 endpoints
- Changes the return type of
InvalidAKVUrlTrustedEndpointsmethod fromArgumentExceptiontoException
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | Removes TrustedUrlsTest.cs from compilation and reorders other AKV test files |
| TrustedUrlsTest.cs | Completely removes the test file that validated AKV URL endpoints |
| ExceptionTestAKVStore.cs | Replaces references to TrustedUrlsTest with inline error message validation |
| Utils.cs | Changes return type of InvalidAKVUrlTrustedEndpoints from ArgumentException to Exception |
| Constants.cs | Reduces AzureKeyVaultPublicDomainNames array from 12 to 8 trusted endpoints |
paulmedynski
changed the title
apoorvdeshmukh
approved these changes
Jul 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3507 +/- ##
===============================================
+ Coverage 66.04% 67.47% +1.43%
===============================================
Files 281 281
Lines 62416 62408 -8
===============================================
+ Hits 41221 42112 +891
+ Misses 21195 20296 -899
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #3486.