Merge | SqlAppContextSwitchManager #3389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup package references in common project
benrr101
added
the
Common Project 🚮
There was a problem hiding this comment.
Pull Request Overview
This PR moves the SqlAppContextSwitchManager file into the common project, renames its suffix from "NetCoreApp" to "netcore", and wraps the file in a conditional compilation block. It also updates the project files to clean up item groups and adjust references based on the target framework.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAppContextSwitchManager.netcore.cs | Added a "#if NET" wrapper around the file. |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj | Reorganized and updated references and package items for better clarity and framework separation. |
| src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj | Updated compile includes to reference the newly located file and removed the old file reference. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3389 +/- ##
==========================================
- Coverage 63.51% 62.17% -1.34%
==========================================
Files 293 291 -2
Lines 63810 63677 -133
==========================================
- Hits 40526 39592 -934
- Misses 23284 24085 +801
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
previously approved these changes
Jun 4, 2025
paulmedynski
previously approved these changes
Jun 10, 2025
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
benrr101
force-pushed
the
dev/russellben/merge/appcontextswitchmanager
branch
from
4371c59 to
1542764
Compare
paulmedynski
previously approved these changes
Jun 12, 2025
paulmedynski
previously approved these changes
Jun 20, 2025
paulmedynski
previously approved these changes
Jun 20, 2025
mdaigle
previously approved these changes
Jun 20, 2025
cheenamalhotra
approved these changes
Jun 23, 2025
mdaigle
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very simple PR, SqlAppConextSwitchManager was moved into common project, suffix changed from NetCoreApp to netcore. File was wrapped in #if NET. Required package reference was added to common project, and I took the opportunity to clean up the item groups a bit.
Issues
More work towards #1261
Testing
Just moving stuff around, CI should provide validation.