Skip to content

Enable central package management in repo #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Enable central package management in repo #3333

wants to merge 12 commits into from

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented May 7, 2025 •
edited
Loading

Onboarding to modern central package management solution. For reference: https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management#enabling-central-package-management

Also fixed #3330

@cheenamalhotra cheenamalhotra requested a review from a team May 7, 2025 00:32
@cheenamalhotra cheenamalhotra added this to the 6.1-preview2 milestone May 7, 2025
@Tornhoof
Copy link

Tornhoof commented May 7, 2025

Personally I'd recommend enabling transivite pinning too:
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#transitive-pinning
to allow for e.g. specific versions of transitive packages without e.g. security vulnerabilities.

paulmedynski
paulmedynski requested changes May 7, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting nits.

@cheenamalhotra cheenamalhotra requested review from paulmedynski and a team May 7, 2025 15:52
@cheenamalhotra cheenamalhotra mentioned this pull request May 7, 2025
Open
paulmedynski
paulmedynski previously approved these changes May 7, 2025
View reviewed changes
benrr101
benrr101 previously approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not bad. It's kinda doing the same thing we were doing just with built-in support.

mdaigle
mdaigle reviewed May 7, 2025
View reviewed changes
Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some notes on things that changed.

@cheenamalhotra cheenamalhotra dismissed stale reviews from benrr101 and paulmedynski via 2ddb065 May 20, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdaigle mdaigle mdaigle left review comments

@paulmedynski paulmedynski paulmedynski approved these changes

@benrr101 benrr101 benrr101 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

Cannot build because of powershell target
5 participants
@cheenamalhotra @Tornhoof @benrr101 @mdaigle @paulmedynski