Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Microsoft.Extensions.Caching.Memory to 6.0.3 for netfx #3004

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

mdaigle
Copy link
Contributor

@mdaigle mdaigle commented Nov 14, 2024

@mdaigle
Copy link
Contributor Author

mdaigle commented Nov 14, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra cheenamalhotra added this to the 6.0-preview3 milestone Nov 14, 2024
else
{
// Otherwise, use the Remove function to remove all entries using all keys in the cache gathered using reflection.
PropertyInfo cacheEntriesCollectionDefinition = typeof(MemoryCache).GetProperty("EntriesCollection", System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EntriesCollection property was removed, causing the private reflection to fail.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (ec82fcb) to head (3f5dda0).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   72.45%   72.47%   +0.02%     
==========================================
  Files         288      288              
  Lines       59498    59493       -5     
==========================================
+ Hits        43109    43120      +11     
+ Misses      16389    16373      -16     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.42% <ø> (+0.04%) ⬆️
netfx 70.93% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdaigle mdaigle merged commit ba15ee2 into dotnet:main Nov 14, 2024
144 checks passed
@mdaigle mdaigle deleted the bump-caching-package branch November 14, 2024 22:55
@mdaigle mdaigle added the ➕ Code Health Issues/PRs that are targeted to source code quality improvements. label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➕ Code Health Issues/PRs that are targeted to source code quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants