Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Documentation Fixes - Batch 5 #2864

Merged
merged 4 commits into from
Sep 20, 2024
Merged

XML Documentation Fixes - Batch 5 #2864

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb009b1
Batch 5 part 1
benrr101 Sep 10, 2024
18437cc
Batch 5 part 2
benrr101 Sep 10, 2024
cd26c0f
Finishing up changes to batch 5
benrr101 Sep 12, 2024
a1c66d7
PR Comments
benrr101 Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PR Comments
  • Loading branch information
@benrr101
benrr101 committed Sep 19, 2024
commit a1c66d7ceded3e35a4f4ad0ba55853db7ab44078
2 changes: 1 addition & 1 deletion doc/snippets/Microsoft.Data.SqlClient/SqlConnectionStringBuilder.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@
// Keys you have provided return true.
Console.WriteLine(builder.ContainsKey("Server"));

// Comparison is case insensitive, and synonyms
// Comparison is case-insensitive, and synonyms
// are automatically converted to their "well-known"
// names.
Console.WriteLine(builder.ContainsKey("Database"));
Expand Down
5 changes: 4 additions & 1 deletion doc/snippets/Microsoft.Data.SqlClient/SqlException.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
</para>
<code language="c#">
try
{
' {
// code here
}
catch (SqlException sqlEx)
Expand Down Expand Up @@ -307,6 +307,9 @@
<seealso cref="T:Microsoft.Data.SqlClient.SqlErrorCollection" />
<seealso cref="T:Microsoft.Data.SqlClient.SqlError" />
</Errors>
<GetObjectData>
<summary>To be added</summary>
</GetObjectData>
<LineNumber>
<summary>
Gets the line number within the Transact-SQL command batch or stored procedure that generated the error.
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,7 +1459,7 @@ internal SqlException() { }
/// <include file='../../../../doc/snippets/Microsoft.Data.SqlClient/SqlException.xml' path='docs/members[@name="SqlException"]/State/*'/>
public byte State { get { throw null; } }

/// <inheritdoc cref="System.Exception.GetObjectData" />
/// <include file='../../../../doc/snippets/Microsoft.Data.SqlClient/SqlException.xml' path='docs/members[@name="SqlException"]/GetObjectData/*'/>
#if NETFRAMEWORK
[System.Security.Permissions.SecurityPermissionAttribute(System.Security.Permissions.SecurityAction.LinkDemand, Flags = System.Security.Permissions.SecurityPermissionFlag.SerializationFormatter)]
#endif
Expand Down