Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add | Add Workload Identity Support #2159

Merged
merged 8 commits into from
Dec 7, 2023
Merged

Add | Add Workload Identity Support #2159

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
177c0b7
First pass
wsugarman Sep 15, 2023
a0bad5a
Add a few tests and fix build
wsugarman Sep 16, 2023
7f1b47e
Fix auth method check
wsugarman Sep 19, 2023
13867ca
Merge branch 'main' into workload-identity
wsugarman Oct 1, 2023
6e6b640
Optionally set client id
wsugarman Oct 1, 2023
12481dd
Merge with main
wsugarman Nov 2, 2023
4a10b59
Add more tests
wsugarman Nov 2, 2023
139bbd6
Merge branch 'main' into workload-identity
wsugarman Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix auth method check
  • Loading branch information
@wsugarman
wsugarman committed Sep 19, 2023
commit 7f1b47eb5b30c80e371b7f27d508072406b8ae70
2 changes: 1 addition & 1 deletion ...soft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ public override async Task<SqlAuthenticationToken> AcquireTokenAsync(SqlAuthenti
return new SqlAuthenticationToken(accessToken.Token, accessToken.ExpiresOn);
}

if (parameters.AuthenticationMethod == SqlAuthenticationMethod.ActiveDirectoryManagedIdentity || parameters.AuthenticationMethod == SqlAuthenticationMethod.ActiveDirectoryMSI)
if (parameters.AuthenticationMethod == SqlAuthenticationMethod.ActiveDirectoryWorkloadIdentity)
{
WorkloadIdentityCredentialOptions options = new()
Copy link
Contributor Author

@wsugarman wsugarman Sep 16, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the properties are initialized using environment variables: https://github.com/Azure/azure-sdk-for-net/blob/99cc57c41c7fa2a3df564ad0c6a745c001cd4517/sdk/identity/Azure.Identity/src/Credentials/WorkloadIdentityCredentialOptions.cs#L13

Copy link
Member

@cheenamalhotra cheenamalhotra Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is documented well, it should work I suppose. I'll let @David-Engel take final call to review if this feature fits well in the AAD stack potentially in sync with other drivers as well.

{
Expand Down
Loading