Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved build project #1850

Merged
merged 14 commits into from
Dec 1, 2022

Conversation

DavoudEshtehari
Copy link
Contributor

@DavoudEshtehari DavoudEshtehari commented Nov 25, 2022

Introducing DotnetPath property on build.proj to run RunTests command with a full path to the underlying dotnet command.

@DavoudEshtehari DavoudEshtehari added the Area\Tests Issues that are targeted to tests or test projects label Nov 25, 2022
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 69.25% // Head: 69.62% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (96c7670) compared to base (2a54bc5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1850      +/-   ##
==========================================
+ Coverage   69.25%   69.62%   +0.37%     
==========================================
  Files         292      292              
  Lines       61604    61727     +123     
==========================================
+ Hits        42662    42976     +314     
+ Misses      18942    18751     -191     
Flag Coverage Δ
addons 92.38% <ø> (ø)
netcore 73.95% <ø> (+0.60%) ⬆️
netfx 67.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...core/src/Microsoft/Data/SqlClient/SNI/SNICommon.cs 55.12% <0.00%> (-14.23%) ⬇️
...re/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs 68.85% <0.00%> (-9.84%) ⬇️
...Microsoft/Data/ProviderBase/DbConnectionFactory.cs 17.04% <0.00%> (-3.41%) ⬇️
...e/src/Microsoft/Data/SqlClient/SNI/SNITcpHandle.cs 61.85% <0.00%> (-1.64%) ⬇️
.../Microsoft/Data/SqlClient/SNI/SNIMarsConnection.cs 76.72% <0.00%> (-0.63%) ⬇️
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs 68.46% <0.00%> (-0.43%) ⬇️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 70.84% <0.00%> (-0.21%) ⬇️
...tcore/src/Microsoft/Data/SqlClient/SNI/SNIProxy.cs 76.25% <0.00%> (ø)
...core/src/Interop/SNINativeMethodWrapper.Windows.cs 98.83% <0.00%> (ø)
.../Microsoft/Data/Common/DbConnectionStringCommon.cs 64.05% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

RunTests.cmd Outdated Show resolved Hide resolved
Co-authored-by: David Engel <dengel1012@gmail.com>
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comment suggestions. Approved with or without them.

BUILDGUIDE.md Outdated Show resolved Hide resolved
RunPackageReferenceTests.cmd Outdated Show resolved Hide resolved
DavoudEshtehari and others added 2 commits November 30, 2022 16:41
Co-authored-by: David Engel <dengel1012@gmail.com>
@DavoudEshtehari DavoudEshtehari merged commit 22eb6c7 into dotnet:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area\Tests Issues that are targeted to tests or test projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants