Chore - Alphabetically sort the compiled files in the netfx and netcore csprojs #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There lots of housecleaning to do, glad you're here helping out with it :) |
cheenamalhotra
added
the
Code Health 💊
johnnypham
approved these changes
Jan 24, 2022
DavoudEshtehari
requested review from
JRahnama,
Kaur-Parminder and
DavoudEshtehari
DavoudEshtehari
approved these changes
Mar 9, 2022
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj
Show resolved
Hide resolved
JRahnama
approved these changes
Mar 9, 2022
…eReferencesInProject # Conflicts: # src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj # src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some of the compiled files are not in the correct ItemGroup/section and it's semi-alphabetically sorted, so as mentioned in #1345 (comment) and in the efforts of #1261 , I hope that this will make it easier to place the merged shared code base files.